Build step

[fhendrikx]

Hi all,

I'm new to ubuntu-touch, however, I have plenty of software development experience. I wanted to see a port for the pixel 3 XL (crosshatch), but since no one has stepped up, I thought I might give it a go.

I have some questions/problems that I would like some thoughts on.

1. I'm aware of the pixel 3 (blueline), but didn't spot a lineageos repo for the "common" code (bluecross). Is this worth tracking down? (I'm also aware of some repos on github that involve bluecross, but unsure how this would apply in this situation).

2. I've forked the google device, kernel (both from lineageos) and vendor blobs (from the muppets), taken the lineageos-16 branch and created a halium-9.0 branch from that, I assume this is sensible?

3. When applying hybris patches, two of them complain about whitespace... is this an actual issue? (or something I can safely ignore)

Applying: Adjust permissions of socket. Provides a connection to a per-user remote trust-store implementation via a unix domain socket.
.git/rebase-apply/patch:79: trailing whitespace.
        int rc = ::bind(socketFd, reinterpret_cast<sockaddr*>(&address), sizeof(sockaddr_un));
warning: 1 line adds whitespace errors.

Applying: (halium) init: ignore non-kernel messages in ReadUevent
.git/rebase-apply/patch:25: trailing whitespace.

warning: 1 line adds whitespace errors.

4. When running breakfast, it says

including vendor/lineage/vendorsetup.sh
Trying dependencies-only mode on a non-existing device tree?

Am I missing something here?

5. When running 'mka mkbootimg', it says:

error: device/google/crosshatch/recovery/Android.bp:17:1: "librecovery_ui_crosshatch" depends on undefined module "libnos_for_recovery"
error: device/google/crosshatch/recovery/Android.bp:17:1: "librecovery_ui_crosshatch" depends on undefined module "libnos_citadel_for_recovery"
ninja: build stopped: subcommand failed.
19:25:11 soong bootstrap failed with: exit status 1

#### failed to build some targets (02:03 (mm:ss)) ####

This looks like a missing library include, however, I don't seem to have this dependency anywhere. I did find some code refs on the net that say:

TARGET_RECOVERY_UI_LIB := \
  librecovery_ui_crosshatch \
  libnos_citadel_for_recovery \
  libnos_for_recovery

but I'm unsure how to pull these libraries into the halium tree.

Appreciate any thoughts or help.

Thanks,
Ferry

[cyn]

Replicate this commit https://gitlab.com/ubports/porting/reference-device-ports/android9/google-pixel-3a/android_device_google_bonito/-/commit/ae71c3f961fccd9aa96ff7f799e14b80ac51a7a2