Resurrection of Indicator Upower

Eric H

@paulcarroty
A merge request has been proposed on surya, but another (global) solution is suggested in the comments :
https://gitlab.com/ubports/porting/community-ports/android10/xiaomi-poco-x3/xiaomi-surya/-/merge_requests/20

paulcarroty

Ahoy, there's battery_charging_enabled support in the latest builds and I need beta testers to check the limiting battery's charge.

You need to apply new udev rule from README and install the latest build from Github Actions.

Eric H

@paulcarroty said in Resurrection of Indicator Upower:

Ahoy, there's battery_charging_enabled support in the latest builds and I need beta testers to check the limiting battery's charge.

You need to apply new udev rule from README and install the latest build from Github Actions.

Thanks !
I installed latest build from Github Actions.

Notice that, on surya, default permissions are :

-rwxrwxrwx 1 system system 4096 févr. 17 11:15 battery_charging_enabled
-rw-r--r-- 1 system system 4096 févr. 17 11:15 charging_enabled

I leave them untouched for the first tests
Let me know if you need tests with different permissions

Eric H

@paulcarroty said in Resurrection of Indicator Upower:

I need beta testers to check the limiting battery's charge.

Test 1:

when charge is less than 85%, device charges :

tail /sys/class/power_supply/battery/{battery_,}charging_enabled
==> /sys/class/power_supply/battery/battery_charging_enabled <==
1

==> /sys/class/power_supply/battery/charging_enabled <==
1

when charge is more than 85%, device doesn't charge (and doesn't seem to discharge until unplugged)

tail /sys/class/power_supply/battery/{battery_,}charging_enabled
==> /sys/class/power_supply/battery/battery_charging_enabled <==
0

==> /sys/class/power_supply/battery/charging_enabled <==
1

(when unplugging, the values in the two files return to 1)

Eric H

@paulcarroty

Test 2 (with udev rules) : same results as test 1

I applied udev rules from README :

phablet@ubuntu-phablet:~$ ls -al /sys/class/power_supply/battery/{battery_,}charging_enabled
-rw-rw-r-- 1 phablet system 4096 févr. 17 17:28 /sys/class/power_supply/battery/battery_charging_enabled
-rw-rw-r-- 1 phablet system 4096 févr. 17 17:06 /sys/class/power_supply/battery/charging_enabled

when charge is less than 85%, device charges :

tail /sys/class/power_supply/battery/{battery_,}charging_enabled
==> /sys/class/power_supply/battery/battery_charging_enabled <==
1

==> /sys/class/power_supply/battery/charging_enabled <==
1

when charge is more than 85%, device doesn't charge (and doesn't seem to discharge until unplugged) :

tail /sys/class/power_supply/battery/{battery_,}charging_enabled
==> /sys/class/power_supply/battery/battery_charging_enabled <==
0

==> /sys/class/power_supply/battery/charging_enabled <==
1

(when unplugging, the values in the two files return to 1)

paulcarroty

@Eric-H great job.

paulcarroty

New release with many fixes.

paulcarroty

Yo, power monitoring and fast charging detection are now supported and I need beta testers (again!) to check how well it works.

You need to install the latest build from Github Actions and start charging your device. If something is wrong - submit your power.txt.

Eric H

@paulcarroty
I installed latest build, and the app no longer starts.

https://dpaste.com/6CTBE25DB

paulcarroty

@Eric-H fixed.

Eric H

@paulcarroty
Reinstalled.
Does not work on surya.

https://dpaste.com/G66MBRASC

Eric H

About this error :
ValueError: could not convert string to float: '3,65353'

Maybe it is a localization error (french) : there is a comma instead of a point

paulcarroty

@Eric-H yeah, upower depends on current locale. Fixed by enforcing

Eric H

@paulcarroty
Reinstalled. It seems to work fine.
Do you need specific tests ?

paulcarroty

@Eric-H test fast charging if you have the hardware for.

Eric H

@paulcarroty
Sorry, I couldn't do the test before today...

So I used the Xiaomi charger supplied with the phone (which fully charges in less than half an hour) with the latest version (0.7) of uPower, but it seems that fast charging is not detected and there's nothing related in the logs.

paulcarroty

Eric-H Attach the power.txt file when the battery is being charged and has less than 50% capacity.

Eric H

@paulcarroty
I tried to generate the power.txt file but there is an error on stderr :

cat: '/sys/devices/platform/soc/c440000.qcom,spmi/spmi-0/spmi0-00/c440000.qcom,spmi:qcom,pm6150@0:qcom,qpnp-smb5/power_supply/main/health': Invalid argument

The health files exists and is world readable :

phablet@ubuntu-phablet:~/tmp$ ls -al /sys/devices/platform/soc/c440000.qcom\,spmi/spmi-0/spmi0-00/c440000.qcom\,spmi\:qcom\,pm6150@0\:qcom\,qpnp-smb5/power_supply/main/health 
-r--r--r-- 1 system system 4096 mai    6 06:21 /sys/devices/platform/soc/c440000.qcom,spmi/spmi-0/spmi0-00/c440000.qcom,spmi:qcom,pm6150@0:qcom,qpnp-smb5/power_supply/main/health

The error persists even if I try to

add double quotes,
add simple quotes
replace cat with tail

Eric H

@paulcarroty
For some unknown reason, today the message on stderr did not appear.

So here is the power.txt file for surya attached.
or see at https://dpaste.org/hCcZO

I can see POWER_SUPPLY_CHARGE_TYPE=Fast in udev battery info, so it seems to be a fast charge.
What should Indicator Upower display ?

paulcarroty

@Eric-H said in Resurrection of Indicator Upower:

I can see POWER_SUPPLY_CHARGE_TYPE=Fast in udev battery info, so it seems to be a fast charge.

No, I got Fast with low-end 7W charger too. My guess it's POWER_SUPPLY_FASTCHARGE_MODE=1. My device has POWER_SUPPLY_HI_POWER.

How much power can your charger deliver? POWER_SUPPLY_POWER_NOW=39764516 looks realistic for 45W.

I also tried to find the Fast Charging voltage (9..12V) on BMS and failed, so you can try it too. Probably not being monitored by software. And all of this is very device-specific.