Testing the upgrade to Qt 5.12

kugiigi

Some apps with custom splash image are too stretched out like for example Gallery.
It's also the same as Talaan and the common thing with them is that the custom splash images are both png instead of SVG. My guess is that the current behavior is that the size is based on the image size but with qt5.12, it's always stretched vertically or horizontally.

dobey

@kugiigi The problem is that Image {} can't magically determine the intent of app devs showing splash screen, and some define it incorrectly. There's an updated splash in gallery-app on GitLab but it hasn't been released yet. But even these new splashes will have some problems in certain situations, and won't work for all possible window sizes under Lomiri. It just happens that apparently some changes in Qt 5.12 are exposing these issues to us.

So, we need to define the expected behavior for X-Ubuntu-Splash-Image better, and stick to that, and then if there are still more complaints about size or scaling, the apps need to be fixed. So, what is the opinion of @CiberSheep and UX group here?

The old Ubuntu platform guide says this on it:

File name of an image present in the directory stated in the Path entry. The splash image is centered on the splash screen and displayed in its actual size (ie, it's not stretched or shrunk and aspect ratio is kept).

mymike

@dobey said in Testing the upgrade to Qt 5.12:

File name of an image present in the directory stated in the Path entry. The splash image is centered on the splash screen and displayed in its actual size (ie, it's not stretched or shrunk and aspect ratio is kept).

For vector images, the splash screen has always scaled the image to fill the minimum value between window width and height. Not sure if we want to change that or keep it...

dobey

OK. Did a little more poking at the Splash, and I think I have it working more like it was before, without the weird artifacts happening. Please upgrade and test again. Thanks!

dobey

Well, that didn't seem to really fix everything, and with more poking about at the X-Ubuntu-Splash-Image handling I'm surprised it every worked as described in the platform guide. I can't seem to get a configuration of the Image {} component which provides the behavior described there, and which also provides a usable experience with the sample set of apps installed on my test device, nor in my VM running unity8 on 16.04.

danfro

Just pulled the latest devel update for my E5, devel.

Calendar app does crash on startup. http://paste.ubuntu.com/p/F4WjzkkQh9/

Notes app does open, but too only gives blank screen when opening a date picker. http://paste.ubuntu.com/p/XYrxkX2PNd/

FluffyChat works, also bottom edge. Although when opeing that the first time it took a few seconds to open up.

Teleports + dekko blank screen on startup.

uTorch does crash after it has lost focus.

Farkle, sprint app, ThemeSwitch, Logviewer, terminal, music app, gallery app, weather app, docviewer, file manager, calculator are working (basic functions).

Ok, thats for a first feedback.

CiberSheep

@dobey said in Testing the upgrade to Qt 5.12:

The old Ubuntu platform guide says this on it:

File name of an image present in the directory stated in the Path entry. The splash image is centered on the splash screen and displayed in its actual size (ie, it's not stretched or shrunk and aspect ratio is kept).

I think this is a good way of going. On Qt 5.9 the image is scaled to the smallest size but that works kind of funny on the tablet.

If that's possible to implement, we can add that to the HIG and change any app that need fixing afterwards.

dobey

@danfro said in Testing the upgrade to Qt 5.12:

Calendar app does crash on startup

Is the pastebin from the log file, or from using the run-click.sh script I posted above to run it from CLI?

Notes app does open, but too only gives blank screen when opening a date picker.

I've opened a PR against notes app to fix this now.

uTorch does crash after it has lost focus.

It seems to work OK here on my e4.5. Can you run it using the script I posted above to see what happens?

dobey

@CiberSheep I don't think it can be implemented as described, and give a good result. IIRC, the idea was for it to allow people to provide a phone-sized image, but that clearly doesn't translate to tablets or PCs.

I can implement it such that there is a maximum square area that matches the smallest edge, and we can have the image scaled/cropped for that area, but there will still be situations where the result it gives us will not be what app devs desire for their splash images.

CiberSheep

@dobey said in Testing the upgrade to Qt 5.12:

I can implement it such that there is a maximum square area that matches the smallest edge, and we can have the image scaled/cropped for that area, but there will still be situations where the result it gives us will not be what app devs desire for their splash images.

It has to be a square, then?
I would say scaled rather than cropped if possible
Developer, we will have to work around the limitations. All is knowing how it works before hand.

dobey

@CiberSheep said in Testing the upgrade to Qt 5.12:

It has to be a square, then?

I would say yes, because it's the only way we can have any sort of guarantee for something reasonable across all form factors.

I would say scaled rather than cropped if possible

I think both PreserveAspectCrop and PreserveAspectFit will likely behave the same way with what I described, anyway, since the image will always be smaller than the window.

Developer, we will have to work around the limitations. All is knowing how it works before hand.

Right. We need a proper and accurate description of the behavior, for which we can judge against when any complaint is made about that behavior to determine if said complaint is a valid issue or not (ie, whether we need to fix it in Lomiri, or app dev needs to fix their image). I don't think the current description is accurate for what the code is doing, and if we modify the code to actually behave that way, it will not give the desired effect in most cases. Though, if we want the existing description to stand, I can certainly make it work that way.

CiberSheep

@dobey said in Testing the upgrade to Qt 5.12:

I would say yes, because it's the only way we can have any sort of guarantee for something reasonable across all form factors.

Vertical splash images from Sailfish or Seedsheep look ok only on portrait, true. Square it is then

Though, if we want the existing description to stand, I can certainly make it work that way.

The only thing I can think of is: scale down the splash image to the size of the screen but when scaling up, maximum to the size of the image.
Say, fit a 512x512 image in smaller screen but show the corresponding image size in tablet (without scaling it up)

The idea would be showing a relatively same image across devices.

dobey

@CiberSheep OK. So, in the current build I have changed the code to accurately behave according to the existing description. In this way there is no scaling, and the image is centered.

Please try it with many apps and let me know what you think.

kugiigi

A bit less important but I'll report anyway and with the upcoming Volla and Fxtec, this might be more noticeable to users

The icons in the indicator gets squished in the external display with the exemption of some.

And going back to the device screen expands them. I think I've encountered this issue before from to time to time though so this isn't exactly new but with Qt5.12, it seems that it always happen.

danfro

@dobey Ok, finally found time to run some tests.

Is the pastebin from the log file, or from using the run-click.sh script I posted above to run it from CLI?

It is from logviewer.

I've opened a PR against notes app to fix this now.

Great!

It seems to work OK here on my e4.5. Can you run it using the script I posted above to see what happens?

Ok, whenever I try to start an app via terminal app with bash runclick.sh com.ubuntu.clock, I do get the same error:

aa-exec_ ERROR: profile 'com.ubuntu.clock_clock_3.12.5' does not exist

danfro

Just my findings, may they help others:

Running Rodneys script from terminal app from within the phone does not seem to work. But using adb shell works great!

If you need to find the proper names of the apps to run them, use click list (thanks Rodney for this hint). Copy/paste possible in adb shell for even more convenience.

CiberSheep

@dobey said in Testing the upgrade to Qt 5.12:

@CiberSheep OK. So, in the current build I have changed the code to accurately behave according to the existing description. In this way there is no scaling, and the image is centered.

Please try it with many apps and let me know what you think.

Updated and testing.

I think it works good for staged splash
With side staged or windowed, not so. Is it possible to scale down to fit the window size on those cases (when splash image is bigger than the window)?

danfro

Hm. When changing from one view to another in calendar app, the first time I enter a view, the header gets messed up. After switching back and entering a second time, things look fine.

Just me? (Testing a few other things, so might be.)

The only entry in log (Logviewer) that seems to be new is this:

file:///opt/click.ubuntu.com/com.ubuntu.calendar/0.8.4.2/qml/EventListModel.qml:183: TypeError: Value is undefined and could not be converted to an object
file:///opt/click.ubuntu.com/com.ubuntu.calendar/0.8.4.2/qml/DayView.qml:94: TypeError: Cannot call method 'scrollToTime' of null

CiberSheep

@danfro this might be a state that has no default or the when condition is checked before the boolean is ready

dobey

@danfro said in Testing the upgrade to Qt 5.12:

Just me? (Testing a few other things, so might be.)

Nope, but I haven't found anything in logs that would point to the cause, other than the fact that Tabs is deprecated.