Testing the upgrade to Qt 5.12

CiberSheep · 5 Nov 2020, 23:22

@dobey said in Testing the upgrade to Qt 5.12:

I would say yes, because it's the only way we can have any sort of guarantee for something reasonable across all form factors.

Vertical splash images from Sailfish or Seedsheep look ok only on portrait, true. Square it is then

Though, if we want the existing description to stand, I can certainly make it work that way.

The only thing I can think of is: scale down the splash image to the size of the screen but when scaling up, maximum to the size of the image.
Say, fit a 512x512 image in smaller screen but show the corresponding image size in tablet (without scaling it up)

The idea would be showing a relatively same image across devices.

dobey · 6 Nov 2020, 14:57

@CiberSheep OK. So, in the current build I have changed the code to accurately behave according to the existing description. In this way there is no scaling, and the image is centered.

Please try it with many apps and let me know what you think.

kugiigi · 6 Nov 2020, 15:28

A bit less important but I'll report anyway and with the upcoming Volla and Fxtec, this might be more noticeable to users

The icons in the indicator gets squished in the external display with the exemption of some.

And going back to the device screen expands them. I think I've encountered this issue before from to time to time though so this isn't exactly new but with Qt5.12, it seems that it always happen.

danfro · 6 Nov 2020, 16:40

@dobey Ok, finally found time to run some tests.

Is the pastebin from the log file, or from using the run-click.sh script I posted above to run it from CLI?

It is from logviewer.

I've opened a PR against notes app to fix this now.

Great!

It seems to work OK here on my e4.5. Can you run it using the script I posted above to see what happens?

Ok, whenever I try to start an app via terminal app with bash runclick.sh com.ubuntu.clock, I do get the same error:

aa-exec_ ERROR: profile 'com.ubuntu.clock_clock_3.12.5' does not exist

danfro · 6 Nov 2020, 19:29

Just my findings, may they help others:

Running Rodneys script from terminal app from within the phone does not seem to work. But using adb shell works great!

If you need to find the proper names of the apps to run them, use click list (thanks Rodney for this hint). Copy/paste possible in adb shell for even more convenience.

CiberSheep · 8 Nov 2020, 00:40

@dobey said in Testing the upgrade to Qt 5.12:

@CiberSheep OK. So, in the current build I have changed the code to accurately behave according to the existing description. In this way there is no scaling, and the image is centered.

Please try it with many apps and let me know what you think.

Updated and testing.

I think it works good for staged splash
With side staged or windowed, not so. Is it possible to scale down to fit the window size on those cases (when splash image is bigger than the window)?

danfro · 8 Nov 2020, 10:47

Hm. When changing from one view to another in calendar app, the first time I enter a view, the header gets messed up. After switching back and entering a second time, things look fine.

Just me? (Testing a few other things, so might be.)

The only entry in log (Logviewer) that seems to be new is this:

file:///opt/click.ubuntu.com/com.ubuntu.calendar/0.8.4.2/qml/EventListModel.qml:183: TypeError: Value is undefined and could not be converted to an object
file:///opt/click.ubuntu.com/com.ubuntu.calendar/0.8.4.2/qml/DayView.qml:94: TypeError: Cannot call method 'scrollToTime' of null

CiberSheep · 8 Nov 2020, 11:56

@danfro this might be a state that has no default or the when condition is checked before the boolean is ready

dobey · 9 Nov 2020, 15:29

@danfro said in Testing the upgrade to Qt 5.12:

Just me? (Testing a few other things, so might be.)

Nope, but I haven't found anything in logs that would point to the cause, other than the fact that Tabs is deprecated.

danfro · 8 Dec 2020, 19:35

In notes app, when opening a note and going back to notes list, the header disappears. I think notes and calendar need to be stripped of the deprecated components to work properly with Qt 5.12.

Header of notes app is the bad boy I suppose. Tabs the bad boy for calendar.

dobey · 8 Dec 2020, 19:35

@danfro said in Testing the upgrade to Qt 5.12:

Header of notes app is the bad boy I suppose.

I'm not sure what's going on or why, but it also happens if you just type the search icon and then go back. It looks like the bottom edge pops up a little while pushing the main header off screen, and then disappears again, leaving the main header hidden.

NoelFlantier · 15 Dec 2020, 07:48

Hi everyone and thanks for all the amazing work on this,
I tried the upgrade during the week end on OnePlus3T, i only noticed two things :

-The front camera view was upside down, but photographs were still properly oriented (no issue with rear camera)

-Dekko2 got stuck at boot, only displaying a white screen, i saw that this has already been reported, so i guess you dont need logs for this, tell me if you do, i will try to add it,

Again big thanks for all your work!