tedit development and design discussion

ma

@danfro Is there a way to sort the files by name again? And how are the sorted by now?

danfro

@ma I am afraid, but I can't say right now why sorting is broken. I will investigate and try to fix that. For sure alphabetical order is easier to use.

Using the search is likely the best option to get along for the moment.

ma

@danfro Okay, thanks.

domubpkm

@danfro I hadn't even paid attention to the broken sorting mode ! Perhaps this is an opportunity to implement different sorting modes internal to tedit or for tedit to conform to the sorting mode defined for Files?

danfro

@domubpkm you are not wrong here.

So (you and others): how many files do you have in tedit? Thinking about performance. Sorting in qml is likely easier but c++ is more performant for larger number of files?

a) less than 100 files
b) 100 to 500 files
c) 500 to 1000 files
d) 1000+ files

messayisto

@danfro a is my answer

domubpkm

@danfro b) This suggests that having a file count indicator might be good too

danfro

@domubpkm like the already existing text at the top of the file list saying how many files where found?

domubpkm

@danfro It already exists! A simple light bolding will suffice!

danfro

@domubpkm not that simple. Either we use html tags withing the text, which makes it cloggy for translations (I generally try to avoid that for this reason) or splitting up the text into two separate labels, then loosing context for translation, because its two separate strings.
I would not make the whole text bold.
Since the number is a %1 placeholder, only "bolding" that by making it <b>%1</b> might be the least bad regarding translations. Still not ideal.

domubpkm

@danfro I was not enough accurate : indeed i spoke of the number only : a little more in bold (maybe).

ma

I use less then 100 files.

danfro

@domubpkm Yes, I understood it that way. I just wanted to explain why even this isn't "simple" codewise.

Thanks for your replies regarding number of files. So I did try a few things and decided to separate the number from the text. Now here everyone can test the latest build with bold number and sorting option for files :
https://gitlab.com/Danfro/tedit/-/jobs/14451001364/artifacts/file/build/aarch64-linux-gnu/app/tedit.danfro_3.7.0_arm64.click

@ma that will solve the sorting problem quite well I hope.

Please let me know any issues, so I can release this soon.

domubpkm

@danfro Thanks. Unless I misinterpret it, it seems that the sorting by date is reversed: ascending is in fact descending and vice versa.

danfro

@domubpkm Yes, true. I will change that.

Does it need a setting so users can choose the default sorting mode? Currently it would always start with alphabetical/ascending as default, which seems the natural way.

domubpkm

@danfro Yes, I saw that the sorting settings were not preserved and I told myself too hat that starting alphabetic/ascending was normal.

danfro

@domubpkm maybe I make it preserve the last values used. Rather than adding more things to settings page.

danfro

@domubpkm Ok, the lastest build (https://gitlab.com/Danfro/tedit/-/jobs/14463791440/artifacts/file/build/aarch64-linux-gnu/app/tedit.danfro_3.7.0_arm64.click) does store the last setting and uses that the next time.

domubpkm

@danfro That's ok . How are subdirectories and their files considered in sorting ?

danfro

@domubpkm I think the subdirectories letters are used for alphabetical sorting. Its basically one string filename or subdir/filename.

I thought about splitting that, but the more parameters I add, the more complex it gets. I would not add another setting/filter for that.

I can try if I can skip the subdirectory and use the filename instead. That might make the most sense I guess.