Notification LED

Hugehead

Hi,

is there any progress on the notification led to be working? Especially with the notch hiding the notifier symbol, on the OP 6 it is hard to find out for new messages.

Can I do something to test/implement it? Is there some contact person being "responsible" for the OP 6 port?

Keneda

@Hugehead
I I refer to device page https://devices.ubuntu-touch.io/device/enchilada , there is not the hardware for notification led on 6 and 6T.
?

Hugehead

From what i can find on the web the situation is as follows:

OP 6: Notification LED available
https://www.reddit.com/r/oneplus/comments/8ljfbv/does_the_oneplus_6_have_a_notification_led/?rdt=46372
OP 6T: Notification LED NOT available
https://www.reddit.com/r/oneplus/comments/9selal/apparently_the_op6t_does_not_have_a_led/
It seems they removed due to notch shrinking and true AMOLED (always on display) allows to have notification led on screen level.

If on OP6 is a notification LED physically available, would it be possible to implement it? I am open to contribute.

Keneda

@Hugehead
OnePlus 6 not "t" also has amoled display.
If OnePlus 6 really has a led, yes it sure can be implemented.

"Simple" to check if it has, test under android

Hugehead

@Keneda Thank you for the positive answer. There is no need to go for Android. Even in UT, when phone is charged, the LED is ON.

I am not sure, what to do wiuth this information. Where can we go to get the LED support implemented?

Keneda

@Hugehead
First you can try to contact one of the three dev/maintener of the port (you can find them on the bottom of device page), second, you can open an issue on the device git : https://gitlab.com/ubports/porting/community-ports/android9/oneplus-6/oneplus-enchilada-fajita/-/issues

Hugehead

@Keneda I saw the contacts there but i was not sure if i could ping them directly as in the telegram group it was mentioned "not to ping people directly unless they are supporting you". i will go that path.

Thank you so far for your support already.

Keneda

@Hugehead
I don't know for telegramm, but if they have account on the forum you can try to ping them here ^^

@Lakotaubp device page seems to be wrong on notif led for OP6, can you do something ?

Lakotaubp

@Keneda Will check later had a very quick look and can't see anything for Notification on either 16 or 20.04 To early for eyes to work.

Lakotaubp

@Keneda Knew I was not looking far enough. Hardware does not support notification LED guess that is what you mean.
That seems pretty final to me and it's not listed on the git pages as an issue to fix.
Looks like only one of the OP6 developer or the maintainers can really help with the full answer for that device as this is the statement

Unsupported features
The device hardware does not support these features, if you need them, please consider a different device.

Notification LED
SD card storage
Wireless charging
FM radio
Wired External monitor

@SEVRALT is the maintainer and on the Forum so might be available for a final answer.
Edit: keep in mind their location might make communication a bit difficult.

Keneda

@Lakotaubp said in Notification LED:

Hardware does not support notification LED guess that is what you mean.

Yes that's it.
From @Hugehead photo we can see there definitely is one ^^

Lakotaubp

@Keneda The charging light indicator might be totally different from the same light being used for messge indication etc. That's why I think we need the maintainer or such for a complete answer fir the OP6. All works on the OP5 so device specific on OP6?.

Hugehead

@Lakotaubp I tested today in Android mode. Notifications are also using the LED. E.g. downloading an update or messages will light up in green. i can also set colors in settings.

Lakotaubp

@Hugehead That is Android though does not mean it works out of the box on UT

Hugehead

@Lakotaubp Let me clarify here shortly:

i asked if Notification LED can be implemented
Keneda answering that from device page notification LED not existing
i claim that it exists because i found info on internet
keneda ask me to check if it really exists. I checked, it exists.

I did not mention that it should run out of box, this is why i am asking if we can implement it.

ToDo:

contact the porters for support (Hugehead)
correcting device page information, because clearly the notification LED is not "not existent" but "not implemented" . (Who can do that?)

Lakotaubp

@Hugehead Please then go a head and contact the developers or the maintainer (who has in effect been pinged by being mentioned). There must be a good reason why under UT it does not work on the OP6 as it works on other devices running UT 20.04 . Unless the info you found specifically states will work on Ubuntu Touch 20.04 on the OP6 that info is of little direct use to UT.
Until we know for certain that the indicator can be made to work there is little point in amending the device page.

Hugehead

@Lakotaubp

Until we know for certain that the indicator can be made to work there is little point in amending the device page.

I dont really get the point. The Notification LED on the OP6 is physically available and works on Android. On OP6 device page it says
" The device hardware does not support these features, if you need them, please consider a different device. "
Which does not fit to the notification LED. It is supported by the device hardware. But, it is not implemented. If it will be implemented we dont know yet (like for fingerprint). In my opinion, the notification definitely fits to the category "not working" but i don't want to push to hard on that.

Unless the info you found specifically states will work on Ubuntu Touch 20.04 on the OP6 that info is of little direct use to UT

It doesn't. I just proofed that the notification LED is available (by hardware) on the OP6 and i am asking if it will be possible to implement it. (which i am doubt, to be honest).

here must be a good reason why under UT it does not work on the OP6 as it works on other devices running UT 20.04

My understanding is that the notification LED support is implemented in UT System. But the "low level" or "driver" level of it, isnt it device specific (like talking to network, gps, camera modules)? I understand that LED is generally working in UT , so if not on OP6, there should be a porting issue. No?

Hugehead

@Lakotaubp
One developer told me he is not using OP6 anymore. and the porter SEVRALT wrote me the following statement on telegram:

Which sounds to me pretty much as a "no".

Are the porters - let's say - responsible for their device? I thought there is a bigger community than 1 person per device. Maybe I don't understand the structure very well.

Lakotaubp

@Hugehead That can be pretty much how it goes for a few devices. There is a commitment of time and effort needed to keep ports going and if the main porter for a device stops for what ever reason that can be it.
Please remember that except for a very few everyone here is giving their time for free. So if for whatever reason they stop and no-one else takes up a device development stops.
We do have a small core team of devs who will concentrate on the OS itself and a few core devices. That really is all that can be covered the rest is down to volunteers.
Bit of a simple overview but the basic outlook. Notch support is being worked on and there is a basic work around linked to on the forum (use the search function to find it). I have found out that is should be possible for the indicator to work as on other devices but it will need device specific work as you have found out.

Hugehead

@Lakotaubp
Thank you very much for the explanation. I was actually not aware of that "strict" porters idea, thought that maybe 10-20 volunteers are porting a device somehow together part by part and that i might could have taken a small part like the LED.

Please remember that except for a very few everyone here is giving their time for free.

Totally clear, I also spend hours of testing and re-flashing (not comparable to the porters I guess). But I didn't really came further in terms of notification LED.

Notch support is being worked on and there is a basic work around linked to on the forum (use the search function to find it)

the OP6 is from 2018, which means the notch support could have come during the last 4-5 years. Not being there. I am doubting that there will be something coming soon AND it needs device specific work, which is , as we see, hard at this time.

I am coming from a company where I work in high class customer support. Main goal is always to give reliable information/timeline to our customers very fast. Maybe i am a little too pushy on free/open source project with my expectations. I am learning