• Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Register
  • Login
UBports Robot Logo UBports Forum
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Register
  • Login

tedit development and design discussion

Scheduled Pinned Locked Moved App Development
tediteditorappdevelopmentfeatures
200 Posts 13 Posters 46.4k Views 3 Watching
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Z Offline
      zubozrout @arubislander
      last edited by 9 Apr 2024, 17:52

      I haven't tried but wouldn't placing TextArea into Flickable work, making the TextArea the height of the max(main app window, its content) and making Flickable handle the scroll?

      Albeit it is probably (and unfortunately) not going to automatically scroll down when inserting new lines in edit mode or just scrolling through with keyboard. Additional code to deal with that would be required, if at all possible 😞

      D 1 Reply Last reply 10 Apr 2024, 04:07 Reply Quote 0
      • D Offline
        danfro @zubozrout
        last edited by 10 Apr 2024, 04:07

        @zubozrout The TextArea is already in a Flickable. But the height is attached to the top of the OSK. Otherwise the OSK would hide part of the text when writing, which is not nice. Actually that is what is was before, I fixed that recently.

        I will need to look into that deeper in the future, but for now I don't see an easy solution.

        1 Reply Last reply Reply Quote 1
        • D Offline
          danfro @danfro
          last edited by 10 Apr 2024, 04:09

          Everyone who wishes to give the short toolbar a try feel free to install the click from the latest pipeline.

          I may try to test the folder and file name in one line and a toolbar below. But feel free to share your experience and thoughts about this stage.

          1 Reply Last reply Reply Quote 0
          • D Offline
            danfro
            last edited by 11 Apr 2024, 20:07

            I did implement the exit button with check for unsaved content. And I did come up with this solution for buttons and file name which now allows us to have some more icons:

            e1f146a9-a471-4241-8738-b28290d7db44-grafik.png

            1 Reply Last reply Reply Quote 1
            • A Offline
              ancientsounds @danfro
              last edited by 11 Apr 2024, 20:33

              Hi @danfro , tedit is great as a general purpose text file editor, not just for notes. Because of that, it would be great to have an "Open File" option in the menu, that allows you to browse to any folder on the system, not just notes that have been created and saved from within tedit.

              Thank you for any action on this!

              D 1 Reply Last reply 11 Apr 2024, 21:20 Reply Quote 0
              • D Offline
                danfro @ancientsounds
                last edited by 11 Apr 2024, 21:20

                @ancientsounds I do understand that this would be very convenient. But to achieve this, the app would need to be unconfined. And I would rather try to avoid that. I wrote some explanations in an issue recently.

                You can share files to import them in tedit. I will (hopefully soon) find time to add content hub export too. Also you can create symlinks to tedit's file folder in other locations, as described in the README. I believe this does provide quite some flexibility to use.

                A 1 Reply Last reply 1 May 2024, 18:45 Reply Quote 3
                • D Offline
                  danfro
                  last edited by 12 Apr 2024, 10:57

                  This is as many icons as I can fit on my XperiaX, so I will not add more to make sure it works on smaller devices. Feel free to test the latest build from the pipeline.

                  6a4888d1-b8ac-431c-89e1-2b09b40ec8a7-grafik.png

                  A 1 Reply Last reply 12 Apr 2024, 11:35 Reply Quote 0
                  • A Offline
                    arubislander @danfro
                    last edited by arubislander 4 Dec 2024, 11:38 12 Apr 2024, 11:35

                    @danfro Great work! There is the lock suru icon to fit with the style of the rest. Unfortunately there is no unlock icon, only a lock_broken icon. But maybe you could roll your own based on the lock one with the lock_broken one as a guide? Or is the icon removed when the document is in edit mode?

                    πŸ‡¦πŸ‡Ό πŸ‡³πŸ‡± πŸ‡ΊπŸ‡Έ πŸ‡ͺπŸ‡Έ
                    Happily running Ubuntu Touch
                    Google Pixel 3a (20.04 DEV)
                    JingPad (24.04 preview)
                    Meizu Pro 5 (16.04 DEV)

                    D 1 Reply Last reply 12 Apr 2024, 11:50 Reply Quote 0
                    • D Offline
                      danfro @arubislander
                      last edited by 12 Apr 2024, 11:50

                      @arubislander definitely possible, but... πŸ˜‰ If we later do a read only mode, the lock/locked system icon would be what I would use for that. Also the current lock sticks out, so it is not mistaken for a button. Thats why I kept it so far.

                      But sure, it doesn't fit our UI scheme. I will think about that. Maybe I have an idea. Or someone else has got one, then please share.

                      D 1 Reply Last reply 12 Apr 2024, 11:51 Reply Quote 0
                      • D Offline
                        danfro @danfro
                        last edited by danfro 4 Dec 2024, 11:52 12 Apr 2024, 11:51

                        @danfro Forgot to add, the padlock indicates that the file is encrypted. Not related to the edit area.

                        A 1 Reply Last reply 12 Apr 2024, 14:24 Reply Quote 0
                        • A Offline
                          arubislander @danfro
                          last edited by 12 Apr 2024, 14:24

                          @danfro said in tedit development and design discussion:

                          the padlock indicates that the file is encrypted. Not related to the edit area.

                          Ah, that makes sense.

                          πŸ‡¦πŸ‡Ό πŸ‡³πŸ‡± πŸ‡ΊπŸ‡Έ πŸ‡ͺπŸ‡Έ
                          Happily running Ubuntu Touch
                          Google Pixel 3a (20.04 DEV)
                          JingPad (24.04 preview)
                          Meizu Pro 5 (16.04 DEV)

                          D 1 Reply Last reply 12 Apr 2024, 20:17 Reply Quote 0
                          • D Offline
                            danfro @arubislander
                            last edited by 12 Apr 2024, 20:17

                            @arubislander Maybe this is better. A smaller padlock and one additional button in the toolbar.

                            d1deeece-5693-46cb-bcf6-50c49c1e367c-grafik.png

                            A D 2 Replies Last reply 13 Apr 2024, 14:30 Reply Quote 0
                            • A Offline
                              arubislander @danfro
                              last edited by arubislander 13 Apr 2024, 14:30

                              @danfro that looks very good!

                              πŸ‡¦πŸ‡Ό πŸ‡³πŸ‡± πŸ‡ΊπŸ‡Έ πŸ‡ͺπŸ‡Έ
                              Happily running Ubuntu Touch
                              Google Pixel 3a (20.04 DEV)
                              JingPad (24.04 preview)
                              Meizu Pro 5 (16.04 DEV)

                              1 Reply Last reply Reply Quote 0
                              • D Offline
                                domubpkm @danfro
                                last edited by 13 Apr 2024, 15:29

                                @danfro Possible bug on the exit (X) function.

                                Two scenarios:

                                Opening tedit ---> do not type any text ---> exit function ok.

                                Opening tedit ---> type a text then delete it completely ---> tedit offers to save.

                                Is this wanted?

                                D 1 Reply Last reply 13 Apr 2024, 16:13 Reply Quote 0
                                • D Offline
                                  danfro @domubpkm
                                  last edited by 13 Apr 2024, 16:13

                                  @domubpkm said in tedit development and design discussion:

                                  Opening tedit ---> type a text then delete it completely ---> tedit offers to save.

                                  A TextArea doesn't have an intelligent change detection. So it doesn't "know" if content has been changed. It can't compare content. As a workaround, as soon as any text is entered, it is marked as "changed" by tedit. So yes, this is currently expected behaviour. Although I agree, not perfect.

                                  My only idea would be to constantly keep reading a copy and comparing that. But I don't think that would be good for performance and very reliable. So I am afraid there is not much I can do about it.

                                  D J 2 Replies Last reply 13 Apr 2024, 17:28 Reply Quote 0
                                  • D Offline
                                    domubpkm @danfro
                                    last edited by 13 Apr 2024, 17:28

                                    @danfro said in tedit development and design discussion:

                                    My only idea would be to constantly keep reading a copy and comparing that. But I don't think that would be good for performance and very reliable. So I am afraid there is not much I can do about it

                                    Just an idea : add option 'tedit exit without saving' in saving' window.

                                    D 1 Reply Last reply 13 Apr 2024, 18:37 Reply Quote 0
                                    • D Offline
                                      danfro @domubpkm
                                      last edited by 13 Apr 2024, 18:37

                                      @domubpkm said in tedit development and design discussion:

                                      Just an idea : add option 'tedit exit without saving' in saving' window.

                                      You are right. I didn't cover this option yet. I assumed the user always wants to save = not loose data. But of course sometimes it is fine to drop changes. Thanks for testing and for the feedback.

                                      D 2 Replies Last reply 13 Apr 2024, 18:58 Reply Quote 0
                                      • D Offline
                                        domubpkm @danfro
                                        last edited by 13 Apr 2024, 18:58

                                        @danfro screenshot20240413_205304283.png screenshot20240413_205336582.png

                                        Particularly in these two cases, the contrast of the options line is a little weak in my opinion.

                                        D 1 Reply Last reply 13 Apr 2024, 19:54 Reply Quote 0
                                        • D Offline
                                          danfro @domubpkm
                                          last edited by 13 Apr 2024, 19:54

                                          @domubpkm Hmm, true the contrast is not ideal. I will need to investigate if we can set this color. But if there is no easy way, I may need to leave this for another release though. Good catch, I missed that.

                                          1 Reply Last reply Reply Quote 0
                                          • D Offline
                                            domubpkm @danfro
                                            last edited by 14 Apr 2024, 00:02

                                            @danfro Tested last built. That's great for me. screenshot20240414_014956759.png
                                            But, since 'save as' output is still active, perhaps a more appropriate title would be 'exit choice'?

                                            D 1 Reply Last reply 14 Apr 2024, 20:00 Reply Quote 0
                                            72 out of 200
                                            • First post
                                              72/200
                                              Last post