Resurrection of Indicator Upower

[Eric H]

@uxes
Shouldn't device names be curtana, joyeuse, excalibur or gram instead of miatoll ?
https://gitlab.com/ubports/porting/community-ports/android10/xiaomi-redmi-note-9-pro/xiaomi-miatoll/-/tree/focal/overlay/system/etc/deviceinfo/devices?ref_type=heads

[uxes]

@Eric-H it is pretty much possible i did not look how is getting device name implemented, but device is identified as miatoll in logs, and also in releases http://system-image.ubports.com/utnext/arm64/android9plus/daily/ on same level as surya

[Eric H]

@paulcarroty
I installed test build for surya.
It seems to work but it does not stop charging when limit is reached.

Is it related to the following message ?

/bin/sh: 1: cannot create /sys/class/power_supply/battery/charging_enabled: Permission denied

[Eric H]

@uxes It was just an idea.
Sorry for the inconvenience.

[uxes]

Another reboot helped, now indicator works, we can mark miatoll as working, just needed two reboot not just one

[Eric H]

@Eric-H said in Resurrection of Indicator Upower:

/bin/sh: 1: cannot create /sys/class/power_supply/battery/charging_enabled: Permission denied

@paulcarroty I'm currently experimenting a udev rules :

# Set charging permissions so indicator-upower can access it
ACTION=="add|change", SUBSYSTEM=="power_supply", KERNEL=="battery", RUN+="/bin/chmod 0666 /sys/class/power_supply/%k/charging_enabled"

It seems to work. I will confirm later.

[paulcarroty]

New release arrived, thx to all contributors.

[Eric H]

@paulcarroty
I can see on github that v0.5 has been released.
But only v0.4 seems to be available on the open store.

[paulcarroty]

@Eric-H probably the store review still in progress.

[Eric H]

@paulcarroty
Ok.
Thanks for your work.

[AppLee]

Hi @Eric-H

Here is an explanation:

[Eric H]

@paulcarroty
I tested the 0.5 release on surya and I can confirm that it works as expected.

Regarding the udev rule, it works perfectly with permissions 0666.
But if I try 0664, it no longer works…
What is the group of the /sys/class/power_supply/battery/charging_enabled file on other devices?

[uxes]

@Eric-H
miatoll

-rwxrwxrwx 1 system system 4,0K led 19 12:40 /sys/class/power_supply/battery/charging_enabled

[paulcarroty]

@Eric-H try the next rule with 0664:

ACTION=="add|change", SUBSYSTEM=="power_supply", KERNEL=="battery", RUN+="/bin/chmod 0664 /sys/class/power_supply/%k/charging_enabled", RUN+="/bin/chown phablet /sys/class/power_supply/%k/charging_enabled"  

[Eric H]

@paulcarroty
I think it's indeed the right approach.
I will confirm today that it works.

[Eric H]

@paulcarroty
The udev rule is working properly:
-rw-rw-r-- 1 phablet system 4096 janv. 23 09:08 /sys/class/power_supply/battery/charging_enabled
And the content of charging_enabled goes well from 1 to 0 when the charge exceeds 85%.

But, despite this, the device continues to charge beyond 85 % !

(I believe that, on surya and karna, we must have to write in another file.
I will try with `/sys/class/power_supply/battery/battery_charging_enabled )

[Eric H]

@paulcarroty
According to https://android.stackexchange.com/questions/200032/difference-between-system-files-charging-enabled-vs-battery-charging-enabled battery-charging-enabled has a different behavior than charging-enabled.
So I will just make a MR to add the above udev rule in surya and karna.
Thanks for your work

[mihael]

On my N100 I don't have /sys/class/power_supply/battery/charging_enabled but instead I have /sys/class/power_supply/battery/battery_charging_enabled

[Eric H]

@paulcarroty
A merge request has been proposed on surya, but another (global) solution is suggested in the comments :
https://gitlab.com/ubports/porting/community-ports/android10/xiaomi-poco-x3/xiaomi-surya/-/merge_requests/20

[paulcarroty]

Ahoy, there's battery_charging_enabled support in the latest builds and I need beta testers to check the limiting battery's charge.

You need to apply new udev rule from README and install the latest build from Github Actions.