Resurrection of Indicator Upower

[Eric H]

@Eric-H said in Resurrection of Indicator Upower:

/bin/sh: 1: cannot create /sys/class/power_supply/battery/charging_enabled: Permission denied

@paulcarroty I'm currently experimenting a udev rules :

# Set charging permissions so indicator-upower can access it
ACTION=="add|change", SUBSYSTEM=="power_supply", KERNEL=="battery", RUN+="/bin/chmod 0666 /sys/class/power_supply/%k/charging_enabled"

It seems to work. I will confirm later.

[paulcarroty]

New release arrived, thx to all contributors.

[Eric H]

@paulcarroty
I can see on github that v0.5 has been released.
But only v0.4 seems to be available on the open store.

[paulcarroty]

@Eric-H probably the store review still in progress.

[Eric H]

@paulcarroty
Ok.
Thanks for your work.

[AppLee]

Hi @Eric-H

Here is an explanation:

[Eric H]

@paulcarroty
I tested the 0.5 release on surya and I can confirm that it works as expected.

Regarding the udev rule, it works perfectly with permissions 0666.
But if I try 0664, it no longer works…
What is the group of the /sys/class/power_supply/battery/charging_enabled file on other devices?

[uxes]

@Eric-H
miatoll

-rwxrwxrwx 1 system system 4,0K led 19 12:40 /sys/class/power_supply/battery/charging_enabled

[paulcarroty]

@Eric-H try the next rule with 0664:

ACTION=="add|change", SUBSYSTEM=="power_supply", KERNEL=="battery", RUN+="/bin/chmod 0664 /sys/class/power_supply/%k/charging_enabled", RUN+="/bin/chown phablet /sys/class/power_supply/%k/charging_enabled"  

[Eric H]

@paulcarroty
I think it's indeed the right approach.
I will confirm today that it works.

[Eric H]

@paulcarroty
The udev rule is working properly:
-rw-rw-r-- 1 phablet system 4096 janv. 23 09:08 /sys/class/power_supply/battery/charging_enabled
And the content of charging_enabled goes well from 1 to 0 when the charge exceeds 85%.

But, despite this, the device continues to charge beyond 85 % !

(I believe that, on surya and karna, we must have to write in another file.
I will try with `/sys/class/power_supply/battery/battery_charging_enabled )

[Eric H]

@paulcarroty
According to https://android.stackexchange.com/questions/200032/difference-between-system-files-charging-enabled-vs-battery-charging-enabled battery-charging-enabled has a different behavior than charging-enabled.
So I will just make a MR to add the above udev rule in surya and karna.
Thanks for your work

[mihael]

On my N100 I don't have /sys/class/power_supply/battery/charging_enabled but instead I have /sys/class/power_supply/battery/battery_charging_enabled

[Eric H]

@paulcarroty
A merge request has been proposed on surya, but another (global) solution is suggested in the comments :
https://gitlab.com/ubports/porting/community-ports/android10/xiaomi-poco-x3/xiaomi-surya/-/merge_requests/20

[paulcarroty]

Ahoy, there's battery_charging_enabled support in the latest builds and I need beta testers to check the limiting battery's charge.

You need to apply new udev rule from README and install the latest build from Github Actions.

[Eric H]

@paulcarroty said in Resurrection of Indicator Upower:

Ahoy, there's battery_charging_enabled support in the latest builds and I need beta testers to check the limiting battery's charge.

You need to apply new udev rule from README and install the latest build from Github Actions.

Thanks !
I installed latest build from Github Actions.

Notice that, on surya, default permissions are :

• -rwxrwxrwx 1 system system 4096 févr. 17 11:15 battery_charging_enabled
• -rw-r--r-- 1 system system 4096 févr. 17 11:15 charging_enabled

I leave them untouched for the first tests
Let me know if you need tests with different permissions

[Eric H]

@paulcarroty said in Resurrection of Indicator Upower:

I need beta testers to check the limiting battery's charge.

Test 1:

• when charge is less than 85%, device charges :

  tail /sys/class/power_supply/battery/{battery_,}charging_enabled
  ==> /sys/class/power_supply/battery/battery_charging_enabled <==
  1
  
  ==> /sys/class/power_supply/battery/charging_enabled <==
  1
  

• when charge is more than 85%, device doesn't charge (and doesn't seem to discharge until unplugged)

  tail /sys/class/power_supply/battery/{battery_,}charging_enabled
  ==> /sys/class/power_supply/battery/battery_charging_enabled <==
  0
  
  ==> /sys/class/power_supply/battery/charging_enabled <==
  1
  

  (when unplugging, the values in the two files return to 1)

[Eric H]

@paulcarroty

Test 2 (with udev rules) : same results as test 1

I applied udev rules from README :

phablet@ubuntu-phablet:~$ ls -al /sys/class/power_supply/battery/{battery_,}charging_enabled
-rw-rw-r-- 1 phablet system 4096 févr. 17 17:28 /sys/class/power_supply/battery/battery_charging_enabled
-rw-rw-r-- 1 phablet system 4096 févr. 17 17:06 /sys/class/power_supply/battery/charging_enabled

• when charge is less than 85%, device charges :

  tail /sys/class/power_supply/battery/{battery_,}charging_enabled
  ==> /sys/class/power_supply/battery/battery_charging_enabled <==
  1
  
  ==> /sys/class/power_supply/battery/charging_enabled <==
  1
  

• when charge is more than 85%, device doesn't charge (and doesn't seem to discharge until unplugged) :

  tail /sys/class/power_supply/battery/{battery_,}charging_enabled
  ==> /sys/class/power_supply/battery/battery_charging_enabled <==
  0
  
  ==> /sys/class/power_supply/battery/charging_enabled <==
  1
  

(when unplugging, the values in the two files return to 1)

[paulcarroty]

@Eric-H great job.

[paulcarroty]

New release with many fixes.