Resurrection of Indicator Upower

paulcarroty

@Eric-H try the next rule with 0664:

ACTION=="add|change", SUBSYSTEM=="power_supply", KERNEL=="battery", RUN+="/bin/chmod 0664 /sys/class/power_supply/%k/charging_enabled", RUN+="/bin/chown phablet /sys/class/power_supply/%k/charging_enabled"

Eric H

@paulcarroty
I think it's indeed the right approach.
I will confirm today that it works.

Eric H

@paulcarroty
The udev rule is working properly:
-rw-rw-r-- 1 phablet system 4096 janv. 23 09:08 /sys/class/power_supply/battery/charging_enabled
And the content of charging_enabled goes well from 1 to 0 when the charge exceeds 85%.

But, despite this, the device continues to charge beyond 85 % !

(I believe that, on surya and karna, we must have to write in another file.
I will try with `/sys/class/power_supply/battery/battery_charging_enabled )

Eric H

@paulcarroty
According to https://android.stackexchange.com/questions/200032/difference-between-system-files-charging-enabled-vs-battery-charging-enabled battery-charging-enabled has a different behavior than charging-enabled.
So I will just make a MR to add the above udev rule in surya and karna.
Thanks for your work

mihael

On my N100 I don't have /sys/class/power_supply/battery/charging_enabled but instead I have /sys/class/power_supply/battery/battery_charging_enabled

Eric H

@paulcarroty
A merge request has been proposed on surya, but another (global) solution is suggested in the comments :
https://gitlab.com/ubports/porting/community-ports/android10/xiaomi-poco-x3/xiaomi-surya/-/merge_requests/20

paulcarroty

Ahoy, there's battery_charging_enabled support in the latest builds and I need beta testers to check the limiting battery's charge.

You need to apply new udev rule from README and install the latest build from Github Actions.

Eric H

@paulcarroty said in Resurrection of Indicator Upower:

Ahoy, there's battery_charging_enabled support in the latest builds and I need beta testers to check the limiting battery's charge.

You need to apply new udev rule from README and install the latest build from Github Actions.

Thanks !
I installed latest build from Github Actions.

Notice that, on surya, default permissions are :

-rwxrwxrwx 1 system system 4096 févr. 17 11:15 battery_charging_enabled
-rw-r--r-- 1 system system 4096 févr. 17 11:15 charging_enabled

I leave them untouched for the first tests
Let me know if you need tests with different permissions

Eric H

@paulcarroty said in Resurrection of Indicator Upower:

I need beta testers to check the limiting battery's charge.

Test 1:

when charge is less than 85%, device charges :

tail /sys/class/power_supply/battery/{battery_,}charging_enabled
==> /sys/class/power_supply/battery/battery_charging_enabled <==
1

==> /sys/class/power_supply/battery/charging_enabled <==
1

when charge is more than 85%, device doesn't charge (and doesn't seem to discharge until unplugged)

tail /sys/class/power_supply/battery/{battery_,}charging_enabled
==> /sys/class/power_supply/battery/battery_charging_enabled <==
0

==> /sys/class/power_supply/battery/charging_enabled <==
1

(when unplugging, the values in the two files return to 1)

Eric H

@paulcarroty

Test 2 (with udev rules) : same results as test 1

I applied udev rules from README :

phablet@ubuntu-phablet:~$ ls -al /sys/class/power_supply/battery/{battery_,}charging_enabled
-rw-rw-r-- 1 phablet system 4096 févr. 17 17:28 /sys/class/power_supply/battery/battery_charging_enabled
-rw-rw-r-- 1 phablet system 4096 févr. 17 17:06 /sys/class/power_supply/battery/charging_enabled

when charge is less than 85%, device charges :

tail /sys/class/power_supply/battery/{battery_,}charging_enabled
==> /sys/class/power_supply/battery/battery_charging_enabled <==
1

==> /sys/class/power_supply/battery/charging_enabled <==
1

when charge is more than 85%, device doesn't charge (and doesn't seem to discharge until unplugged) :

tail /sys/class/power_supply/battery/{battery_,}charging_enabled
==> /sys/class/power_supply/battery/battery_charging_enabled <==
0

==> /sys/class/power_supply/battery/charging_enabled <==
1

(when unplugging, the values in the two files return to 1)

paulcarroty

@Eric-H great job.

paulcarroty

New release with many fixes.

paulcarroty

Yo, power monitoring and fast charging detection are now supported and I need beta testers (again!) to check how well it works.

You need to install the latest build from Github Actions and start charging your device. If something is wrong - submit your power.txt.

Eric H

@paulcarroty
I installed latest build, and the app no longer starts.

https://dpaste.com/6CTBE25DB

paulcarroty

@Eric-H fixed.

Eric H

@paulcarroty
Reinstalled.
Does not work on surya.

https://dpaste.com/G66MBRASC

Eric H

About this error :
ValueError: could not convert string to float: '3,65353'

Maybe it is a localization error (french) : there is a comma instead of a point

paulcarroty

@Eric-H yeah, upower depends on current locale. Fixed by enforcing

Eric H

@paulcarroty
Reinstalled. It seems to work fine.
Do you need specific tests ?

paulcarroty

@Eric-H test fast charging if you have the hardware for.