Updating apps to 16.04

[zubozrout]

Is there a way I can review the package with clickable to upload to OpenStore?

This is what I am currently getting when I try it: "This app needs to be reviewed manually, please check you app using the click-review command"

[advocatux]

@zubozrout you've posted the answer to your question, you need to run click-review against your package

[zubozrout]

@advocatux Yeah I know, but that package is not available for 18.04, right?

[advocatux]

@zubozrout no, I don't think so

[DanChapman]

@zubozrout something like this should work

$ docker run -it -v $PATH_TO_CLICK_DIR:/clickdir clickable/ubuntu-sdk:16.04-amd64 bash
$ apt install click-reviewers-tools
$ cd /clickdir
$ click-review my.click

[zubozrout]

@danchapman Thanks a lot :).

So now I have this: - lint:framework
'ubuntu-sdk-16.04' is not a supported framework
http://askubuntu.com/questions/460512/what-framework-should-i-use-in-my-manifest-file
transport.zubozrout_0.9.4.3_armhf.click: FAIL

[DanChapman]

@zubozrout ahh i wonder if click-review was updated in the ubports archive to allow the new framework. Try dropping the framework to a 15.04 one and run click-review to see what the real errors are and then bump it back up before pushing to the store as the framework most likely isn't the issue.

[zubozrout]

@danchapman Good idea to test this. It looks like I get the same error for 15.04 (also tested with 15.04.5 which was the framework I originally used for the project).

[zubozrout]

Ok, so there is this ppa https://launchpad.net/~bhdouglass/+archive/ubuntu/clickable with the latest forked package that is even available for bionic :). And it has xenial app support. With that reviewing the packages should work correctly.

[doniks]

@zubozrout
I don't get it. I'm looking at the "This app needs to be reviewed manually, please check you app using the click-review command", but I can't figure out how to proceed from here.

I could run the first two of @DanChapman 's commands (should I have set the PATH_TO_CLICK_DIR variable? to what?).

[hummlbach]

@doniks What Dan meant is: go to the directory where the click is. So often the click is in the build subdirectory. In that case you would have to do a cd build and then click-review name-of-your-click.click. Alternatively you may stay in the directory you are and pass the full path to the click over to click-review. Like click-review /home/doniks/my-app/build/my_app.doniks_1.2.3.click or something like that... And then the funny part will start

[arubislander]

Not to hijack the thread, but I have done this with my click package. It says:

build/usonic.arubislander_0.6.0_all.click: pass

How do I notify the OpenStore Submit process that the package has passed the click-review?

[doniks]

@hummlbach Nope, I still don't get it. Inside the container I never see my click, outside the container I never see click-review

https://paste.ubuntu.com/p/389kxQ9Nfw/

UPDATE: Now, I got it

$ docker run -it -v /home/peter/docs/devel/shorter/build/:/clickdir  clickable/ubuntu-sdk:16.04-amd64 bash
root@8fe1c0f532f8:/# apt install click-reviewers-tools
Reading package lists... Done
[...]
Processing triggers for libc-bin (2.23-0ubuntu10) ...
root@8fe1c0f532f8:/# click-review /clickdir/doniks.shorter_4.4_armhf.click 
ERROR: manifest malformed: unsupported field 'oldframework':
[...]

[hummlbach]

@arubislander Tell Brian in the openstore telegram group for example and give your click package to him.
@doniks Just do the sudo apt-get install click-reviewers-tools command outside the container. And then run it click-review also outside. UPDATE: okay, or like that ideally you could set it up with clickable some how s.t. clickable was doing the work inside the container for you - and you would never see it from the inside again... Badum tssss

[arubislander]

@hummlbach said in Updating apps to 16.04:

@arubislander Tell Brian in the openstore telegram group for example and give your click package to him.

Thanks @hummlbach. Turns out it was some .cpp code I had added to test a feature, but it was superfluous, so I deleted it and now all is well.

[doniks]

modules:composer.user_said_in, @arubislander, Updating apps to 16.04

@hummlbach said in Updating apps to 16.04:

@arubislander Tell Brian in the openstore telegram group for example and give your click package to him.

Thanks @hummlbach. Turns out it was some .cpp code I had added to test a feature, but it was superfluous, so I deleted it and now all is well.

Are you saying that you got your click to pass the click-review and then you could upload it?

[arubislander]

@doniks No, my click package passed the click-review from the outset.
I am saying that removing the c++ code caused the message to go away when uploading it to the open store.
It seems that even when your click package passes the click-review, you still need to have it reviewed by someone from the openstore, before getting it submitted.

[Wendigo]

Is it possible to declare both frameworks for 15.04 and 16.04 together in one manifest.json so that the click package can be installed on both Ubuntu Touch versions?
The App itself is pure HTML5+JS so nothing needs to be compiled.

The current version looks like this:
{
"name": "sakawochi.wendigosoft",
"description": "The micro aquarium that fits into your pocket",
"architecture": "all",
"title": "Sakawochi",
"hooks": {
"sakawochi": {
"apparmor": "sakawochi.apparmor",
"desktop": "sakawochi.desktop"
}
},
"version": "0.2.11",
"maintainer": "Me <me@mymailbox.org>",
"framework" : "ubuntu-sdk-15.04.6"
}
Could I just add a "," or ";" in the framework field?

[dobey]

@wendigo No, you cannot do that. If the app works on both versions, and you want to keep uploading for both versions, I would suggest using the last 15.04 framework and apparmor 1.3 policy version, and just uploading the same package for both xenial and vivid.

However, rather than that, I'd suggest only uploading new versions for xenial. As I understand, the plan is to stop taking new app uploads for vivid soon, perhaps when OTA-5 is released.

[Wendigo]

Thanks, I'll stay with framework 15.04 then and offer it for both versions on OpenStore.
Since not everyone will update to OTA-4 I want to support the old version until OTA-5 is out.