UBports Robot Logo UBports Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Groups
    • Search
    • Register
    • Login

    tedit development and design discussion

    Scheduled Pinned Locked Moved App Development
    tediteditorappdevelopmentfeatures
    200 Posts 13 Posters 46.6k Views 3 Watching
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
      Reply
      • Reply as topic
      Log in to reply
      This topic has been deleted. Only users with topic management privileges can see it.
      • danfroD Offline
        danfro
        last edited by

        And here two screenshots with the short toolbar. open, save and undo I would consider the most used options. This looks fine I think. Xperia X, so no huge screen device.

        5224568196936360168_121.jpg

        5224568196936360166_121.jpg

        D Josele13J M danfroD 4 Replies Last reply Reply Quote 0
        • D Offline
          domubpkm @danfro
          last edited by

          @danfro This is necessary. With 3 options maximum, it makes sense.

          1 Reply Last reply Reply Quote 0
          • Josele13J Offline
            Josele13 @danfro
            last edited by

            @danfro I don't see it necessary but if you want to do it I see this option better than the one you have shown above, maybe the route to find the note is not necessary, I think it's better to put the route in Tedit information.

            Xiaomi Redmi Note 9 pro
            Oneplus Nord 100
            Xiaomi Redmi Note 7
            Nexus 5
            Bq E4.5 Ubuntu edition .... is dead

            danfroD 1 Reply Last reply Reply Quote 0
            • danfroD Offline
              danfro @Josele13
              last edited by

              @Josele13 said in tedit development and design discussion:

              maybe the route to find the note is not necessary, I think it's better to put the route in Tedit information.

              The file storage folder is already named

              1. in the apps about section
              2. in the apps OpenStore description
              3. in the readme of the github

              Users still get confused. This is partly due to how content hub works. Users do not expect that importing a file does copy the file. They think the original file will get modified.
              So I think this does make the file storage folder very clear to avoid misunderstandings and users maybe using data.

              I too will try to improve the descriptions in the above places and maybe add some more details here and there.

              And I need to run some tests to find out if that works with a symlink. So I may change it. But thanks for the opinion and thoughts about it.

              1 Reply Last reply Reply Quote 1
              • M Offline
                ma @danfro
                last edited by

                @danfro This looks very good. Since there is enough space vertically, I would prefere two lines. One line for the file name (including path) and one for the icons.

                With this solution there would be space for additional icons, e.g. redo or open.

                danfroD 1 Reply Last reply Reply Quote 0
                • danfroD Offline
                  danfro @ma
                  last edited by

                  @ma Thanks a lot for the feedback.

                  I am not sure if we rally have that much space vertically. On my Xperia X the edit area, when the OSK is visible, is maybe 1/3 of the screen. And I hope to be able to add a second toolbar with formatting options in the future. So after playing around with this, I am more inclined to use the short toolbar in one row with the file name. The short toolbar would have the actions open, save and undo.

                  Although I agree, some other actions might be nice to have in quick access too. But making this configurable (one option) seems to be complicated to implement without loosing stability.

                  So which other actions woukd you like to have in quick access bar? I think of maybe have a fourth one, maybe depending on the available width or configurable. This would also depend on the general length of your file names. If one uses long file names, the toolbar might be inconvenient.

                  M 1 Reply Last reply Reply Quote -1
                  • M Offline
                    ma @danfro
                    last edited by

                    @danfro Often I just want to read a note. But while scrolling I accidentally change the text. Unfortunately, the keyboard also appears, which takes up about 1/3 of the screen. Therefore I would welcome a "read-only button" that prevents changes and blocks the keyboard.

                    danfroD 1 Reply Last reply Reply Quote 0
                    • danfroD Offline
                      danfro @ma
                      last edited by

                      @ma I think someone else asked for that as well. But when I tested that, making the TextArea readonly also drops all scrolling and pan interaction, so there is no way to navigate through the note. So far I haven't found a way to solve this.

                      arubislanderA 1 Reply Last reply Reply Quote 0
                      • arubislanderA Offline
                        arubislander @danfro
                        last edited by

                        @danfro Instead of making the component readyonly, maybe it could be possible to ignore all keystrokes?

                        πŸ‡¦πŸ‡Ό πŸ‡³πŸ‡± πŸ‡ΊπŸ‡Έ πŸ‡ͺπŸ‡Έ
                        Happily running Ubuntu Touch
                        Google Pixel 3a (20.04 DEV)
                        JingPad (24.04 preview)
                        Meizu Pro 5 (16.04 DEV)

                        danfroD 1 Reply Last reply Reply Quote 0
                        • danfroD Offline
                          danfro @arubislander
                          last edited by

                          @arubislander I guess it would need to prevent the OSK from rising. Ignoring keystrokes is no problem. If you just read, you don't press any keys anyway. The trick is, how to be able to navigate without raising the OSK. Maybe have an "input blocker" above the text area and adding some (external) scroll components. But not sure if thats a good solution, if possible at all.

                          arubislanderA 1 Reply Last reply Reply Quote 0
                          • arubislanderA Offline
                            arubislander @danfro
                            last edited by

                            @danfro Ah, right. The TextArea would need to be prevented from getting direct focus, but still react to swipes for scrolling ... πŸ€”

                            πŸ‡¦πŸ‡Ό πŸ‡³πŸ‡± πŸ‡ΊπŸ‡Έ πŸ‡ͺπŸ‡Έ
                            Happily running Ubuntu Touch
                            Google Pixel 3a (20.04 DEV)
                            JingPad (24.04 preview)
                            Meizu Pro 5 (16.04 DEV)

                            Z 1 Reply Last reply Reply Quote 0
                            • Z Offline
                              zubozrout @arubislander
                              last edited by

                              I haven't tried but wouldn't placing TextArea into Flickable work, making the TextArea the height of the max(main app window, its content) and making Flickable handle the scroll?

                              Albeit it is probably (and unfortunately) not going to automatically scroll down when inserting new lines in edit mode or just scrolling through with keyboard. Additional code to deal with that would be required, if at all possible 😞

                              danfroD 1 Reply Last reply Reply Quote 0
                              • danfroD Offline
                                danfro @zubozrout
                                last edited by

                                @zubozrout The TextArea is already in a Flickable. But the height is attached to the top of the OSK. Otherwise the OSK would hide part of the text when writing, which is not nice. Actually that is what is was before, I fixed that recently.

                                I will need to look into that deeper in the future, but for now I don't see an easy solution.

                                1 Reply Last reply Reply Quote 1
                                • danfroD Offline
                                  danfro @danfro
                                  last edited by

                                  Everyone who wishes to give the short toolbar a try feel free to install the click from the latest pipeline.

                                  I may try to test the folder and file name in one line and a toolbar below. But feel free to share your experience and thoughts about this stage.

                                  1 Reply Last reply Reply Quote 0
                                  • danfroD Offline
                                    danfro
                                    last edited by

                                    I did implement the exit button with check for unsaved content. And I did come up with this solution for buttons and file name which now allows us to have some more icons:

                                    e1f146a9-a471-4241-8738-b28290d7db44-grafik.png

                                    1 Reply Last reply Reply Quote 1
                                    • A Offline
                                      ancientsounds @danfro
                                      last edited by

                                      Hi @danfro , tedit is great as a general purpose text file editor, not just for notes. Because of that, it would be great to have an "Open File" option in the menu, that allows you to browse to any folder on the system, not just notes that have been created and saved from within tedit.

                                      Thank you for any action on this!

                                      danfroD 1 Reply Last reply Reply Quote 0
                                      • danfroD Offline
                                        danfro @ancientsounds
                                        last edited by

                                        @ancientsounds I do understand that this would be very convenient. But to achieve this, the app would need to be unconfined. And I would rather try to avoid that. I wrote some explanations in an issue recently.

                                        You can share files to import them in tedit. I will (hopefully soon) find time to add content hub export too. Also you can create symlinks to tedit's file folder in other locations, as described in the README. I believe this does provide quite some flexibility to use.

                                        A 1 Reply Last reply Reply Quote 3
                                        • danfroD Offline
                                          danfro
                                          last edited by

                                          This is as many icons as I can fit on my XperiaX, so I will not add more to make sure it works on smaller devices. Feel free to test the latest build from the pipeline.

                                          6a4888d1-b8ac-431c-89e1-2b09b40ec8a7-grafik.png

                                          arubislanderA 1 Reply Last reply Reply Quote 0
                                          • arubislanderA Offline
                                            arubislander @danfro
                                            last edited by arubislander

                                            @danfro Great work! There is the lock suru icon to fit with the style of the rest. Unfortunately there is no unlock icon, only a lock_broken icon. But maybe you could roll your own based on the lock one with the lock_broken one as a guide? Or is the icon removed when the document is in edit mode?

                                            πŸ‡¦πŸ‡Ό πŸ‡³πŸ‡± πŸ‡ΊπŸ‡Έ πŸ‡ͺπŸ‡Έ
                                            Happily running Ubuntu Touch
                                            Google Pixel 3a (20.04 DEV)
                                            JingPad (24.04 preview)
                                            Meizu Pro 5 (16.04 DEV)

                                            danfroD 1 Reply Last reply Reply Quote 0
                                            • danfroD Offline
                                              danfro @arubislander
                                              last edited by

                                              @arubislander definitely possible, but... πŸ˜‰ If we later do a read only mode, the lock/locked system icon would be what I would use for that. Also the current lock sticks out, so it is not mistaken for a button. Thats why I kept it so far.

                                              But sure, it doesn't fit our UI scheme. I will think about that. Maybe I have an idea. Or someone else has got one, then please share.

                                              danfroD 1 Reply Last reply Reply Quote 0
                                              • First post
                                                Last post