OSK Enhancements Proposals

  • @kugiigi good job

  • @cibersheep I used the palettes from the official toolkit themes so those are already suru colors πŸ˜‰
    Although I did not explore the more extensive list of suru palettes.
    Do you want to check the design/palettes first or should I create a PR now and just do any changes on that based on your comments? πŸ™‚

    @hummlbach I considered doing that at first, using "theme.palette" and so but it wasn't quite simple to convert since not all the original palettes have equivalent in the toolkit. And personally, I don't think we'll have system-wide theme setting soon especially that the UITK's future is quite bad at the moment. But in any case, we can still have a workaround for maybe setting the theme to Ambiance or SuruDark πŸ™‚

  • @kugiigi I know you used the Suru palette, sorry: I ment that if you want more colors, that list is the Β«officialΒ» additional colors πŸ™‚

    I think you can do a PR and we can work from there, don't you?

  • @kugiigi what about making shadows from qml with DropShadows? honestly I don't like very much that border...

  • @kugiigi here I prefer the first 2 screens and I don't like the ones with borders... how are the magnified key when pressed on the just one color keyboard?

  • @mymike I didn't try that but it might have performance impact I guess?
    You mean the border in the magnifier right?

    I guess the preference depends on the person. I like those with border πŸ™‚ Although in my PR, I updated those a bit, I changed the color of the action keys similar to Ambiance,Suru Dark and Suru Black.

    Magnifier for the pure colors are still bordered.

  • You mean the border in the magnifier right?


    @mymike I didn't try that but it might have performance impact I guess?

    Idk tbh, but I saw you can cache the shadow

    from DropShadows qt docs about the cache property:

    This property allows the effect output pixels to be cached in order to improve the rendering performance. Every time the source or effect properties are changed, the pixels in the cache must be updated.

  • @mymike I can try out using DropShadows and see if it has adverse effect especially with the performance.

  • @CiberSheep If the design team wants to intervene with the themes support, now is the time πŸ˜„
    Pull request

    I did not check/test all the palette assignments thoroughly so I'm not confident the they all look fine πŸ™‚

  • I like Bordered grey, it's the one that looks most like Ambiance dark on the desk

Log in to reply