Test alternative pin code prompt - system settings integration

lduboeuf · 3 Apr 2022, 22:54

Hi all,

I've managed to try adding an alternate pin code prompt based on that work: http://guidopallemans.blogspot.com/2013/09/some-time-ago-i-saw-beautiful-lock.html

As stated here: https://github.com/ubports/ubuntu-touch/issues/1940
One of the task is to add to security system setting a toggle to select the pin code prompt:

And a demo "tester" to be familiar with this new way:

I've pushed an app click demo here: https://open-store.io/app/lockertest.ld
download:( https://open-store.io/api/v3/apps/lockertest.ld/download/xenial/all )

Any feedback welcome.

( For a demo of this pin code prompt integrated in Lomiri: https://user-images.githubusercontent.com/11663835/154673358-5c7c1cfe-f7ce-4d66-98de-e108cd4fba16.mp4 )

source code : https://github.com/lduboeuf/utpincodetester

kugiigi · 3 Mar 2022, 11:55

This is cool and can be really useful on touch devices.
I wish there's a retry button even if the pin code isn't complete yet.

CiberSheep · 3 Mar 2022, 12:41

@lduboeuf Interesting.
I understand why you add the option as a separated ComboButton, but I would add it as a new element of the main ListView

Swipe (no security)...
4-digit passcode
4-digit passcode clock prompt
Passpharse...
Fingerprint...

or even better:

Swipe (no security)...
4-digit passcode... -> Popup with the options
Passpharse...
Fingerprint...

I would not place the try me button in the ComboButton but outside

On the demo page,

I would make the edit button icon smaller
~~- Do you need the lock icon in the middle of the view?~~ I see why now in the test app Maybe a bit smaller?
I would not require to tap on retry to introduce a new pattern (if that's the final behaviour)
There is something with the circles and the numbers that doesn't fit for me. Maybe getting rid of the circles and just leave the numbers? Now it's a bit busy... mmm...

Lakotaubp · 3 Mar 2022, 12:29

@lduboeuf Works well and I like the look, would be nice to have the choice. Thanks for the test.

lduboeuf · 3 Mar 2022, 13:39

@kugiigi said in Test alternative pin code prompt - system settings integration:

This is cool and can be really useful on touch devices.
I wish there's a retry button even if the pin code isn't complete yet.

Yes i wonder where to place that retry button or icon

lduboeuf · 3 Mar 2022, 13:59

@cibersheep said in Test alternative pin code prompt - system settings integration:

@lduboeuf Interesting.
I understand why you add the option as a separated ComboButton, but I would add it as a new element of the main ListView

Swipe (no security)...

4-digit passcode

4-digit passcode clock prompt

Passpharse...

Fingerprint...

Humm, that layout would mean to be able to create a pincode with the "clock". That would need a different work for me

or even better:

Swipe (no security)...

4-digit passcode... -> Popup with the options

Passpharse...

Fingerprint...

Is it UX wise to open a popup or a another page on a OptionSelector item ? I haven't found an example in current system settings

CiberSheep · 3 Mar 2022, 14:09

@lduboeuf

Is it UX wise to open a popup or a another page on a OptionSelector item ? I haven't found an example in current system settings

Actually, if you set «no security» or «passphrase» it will show you a pop up.

lduboeuf · 3 Mar 2022, 14:18

@cibersheep oh yes just noticed that, thx

[EDIT]:
What can be weird is that if "4-digit passcode" item is already selected, having to tap on it again to change the pin code prompt.

Moem · 3 Mar 2022, 15:45

I love this project so much.

I use fingerprint unlocking on the OP 5t; it works most of the time. When it fails, the standard pincode/passphrase unlock comes up. I would love it if I could use fingerprint with this new option as a fallback instead. It's just so cool.

lduboeuf · 3 Mar 2022, 20:23

@cibersheep Aside from that, there is something need to be reworked because actually if you want to change the password/pincode, you need to switch to another option and then back again.
That option list is maybe not the right component to use.
We should have the "change password" action possible for the password and pin code.

I'm a bit stuck how i can handle the above pin code prompt choice with what you said. If you have any mockup, it would be great.

Moem · 3 Mar 2022, 20:31

I would be interested in a feature that allows the numbers to be hidden from view (optionally). Maybe they can be shown if the first try fails? Some of us remember numbers well, others are good with patterns...

lduboeuf · 3 Mar 2022, 20:37

@moem i need to see the impact on storing such custom parameters and if it is recommended.
But your wish is fully understandable

Moem · 3 Mar 2022, 20:52

@lduboeuf said in Test alternative pin code prompt - system settings integration:

your wish is fully understandable

Well that's a first!

messayisto · 3 Mar 2022, 21:23

@lduboeuf very nice! works well on rc channel on xiaomi mi a2. would love to see this in daily use...

CiberSheep · 4 Mar 2022, 12:19

@lduboeuf said in Test alternative pin code prompt - system settings integration:

@cibersheep oh yes just noticed that, thx

[EDIT]:
What can be weird is that if "4-digit passcode" item is already selected, having to tap on it again to change the pin code prompt.

That's where I would go to change it. Now, even if it has ... it does nothing if already selected.

But I see the fingerprints are on the main Security view. Let me make a mockup and let's see if we can find a consistent solution here

CiberSheep · 4 Mar 2022, 12:21

@lduboeuf said in Test alternative pin code prompt - system settings integration:

@moem i need to see the impact on storing such custom parameters and if it is recommended.

Oh, I thought showing the pin was only for the test app to know if that worked.
I don't think is a good idea to have a visible pin code. Or I missed the joke?

lduboeuf · 3 Apr 2022, 15:05

@cibersheep said in Test alternative pin code prompt - system settings integration:

@lduboeuf said in Test alternative pin code prompt - system settings integration:

@moem i need to see the impact on storing such custom parameters and if it is recommended.

Oh, I thought showing the pin was only for the test app to know if that worked.
I don't think is a good idea to have a visible pin code. Or I missed the joke?

This was intentional, the idea was to provide a "test" screen just to be familiar with it in system settings. But i agree, on other platforms, you don't have a "tester", when you choose "pattern", you are asking to create/modify the the pattern.

Here we are in special case where users still define its pin code with keyboard. And i would like users just to choose between default pin code prompt or the "clock" one. Maybe the "tester" is not needed ? And just let user discover it at login time.

kugiigi · 4 Mar 2022, 17:30

Maybe the option can be added directly in the lock screen. Some kind of a button to switch between modes on the fly. Also, would be great if it also support keyboard input for convergence

lduboeuf · 4 Mar 2022, 18:16

@kugiigi yes that could be an option.
Humm in my previous test keyboard was working, but maybe not in the demo ?

CiberSheep · 4 Mar 2022, 19:28

@kugiigi said in Test alternative pin code prompt - system settings integration:

Maybe the option can be added directly in the lock screen.

I don't think that's a good idea

Also, would be great if it also support keyboard input for convergence

and this is a very good point