[edit 2019/11/20] {
Sorry I give up. I have working code but the automated tests fail. Unfortunately the testing framework is even more complicated then unity itself and the things it tests are trivial. I see no use in crafting dbus messages and plugins just to automatically 'test' a led turning white or green.

Small advice: maintaining this test bed is too big a burden for a project this short of man power. I think you really should get rid of it.
}

I want to have the led on my phone show it is being charged or it's battery is full.
One of the core developers on telegram pointed out that this could be done by extending repowerd. So I tried to do that.

[edits] {
2019/11/09 made a PR for unity8
2019/11/07 I am now changing IndicatorsLight.qml. You can already try it. No need to build anything, just replace the qml file (keep a copy).
}

This is my first step in ubports and I have absolutely no clue of the architecture of ubports or the direction it is going into. So any development related reactions are welcome.

What I did:
Created a LightControl that does two things. Control the led (on/off/color etc) and manage the led. With managing I mean show a certain event charging, full, etc.
The battery state is monitored by UPowerPowerSource. I made it pass the BatteryInfo in its changed callback and have DefaultStateMachine pass it along.
Furthermore DefaultStateMachine also notifies display on/off.
Led styles are now hardcoded but could be made to use DeviceConfig.
Currently the led is off when the display is on. It can show charging (white pulsing) and full (solid lime green).

Choice to make

• Currently the led shows dark green when a message is 'new'. This is handled by a qml file in Unity.
  There cannot be two captains on this ship so either Unity must take care of managing the led or repowerd. I opt for repowerd.
• Should the led be controllable through dbus?

Problems

• I need information on how to know the state (or keep track of it) of pending new messages and missed calls.
• I don't have sim card in my phone. How can I test 'pending new message'?

My work can be found in the add-light branch of repo https://github.com/wdehoog/repowerd
Development is done using cross-builder. I test it on my oneplus one.

When interested to test see: https://gist.github.com/wdehoog/c7c09a792799d03e6880e10dbc19ab33

PS.
I have very strong feelings about the testing framework of repowerd. The COC probably forbids me to express them.

@matteo to test your leds. It is also interesting to see the permissions. For example on opo:

phablet@ubuntu-phablet:~$ find /sys -name brightness -ls
    13414      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/f9924000.i2c/i2c-2/2-0068/leds/red/brightness
    13442      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/f9924000.i2c/i2c-2/2-0068/leds/blue/brightness
    13428      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/f9924000.i2c/i2c-2/2-0068/leds/green/brightness
    11561      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/mdp.0/qcom,mdss_fb_primary.169/leds/lcd-backlight/brightness
    19339      0 -rwxrwxrwx   1 system   android_media     4096 Mar  3  1970 /sys/devices/leds-qpnp-f6287e00/leds/led:flash_torch/brightness
    19303      0 -rwxrwxrwx   1 system   android_media     4096 Mar  3  1970 /sys/devices/leds-qpnp-f6287e00/leds/led:flash_0/brightness
    19320      0 -rwxrwxrwx   1 system   android_media     4096 Mar  3  1970 /sys/devices/leds-qpnp-f6287e00/leds/led:flash_1/brightness
    17399      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/leds-qpnp-f628c000/leds/kpdbl-pwm-2/brightness
    17421      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/leds-qpnp-f628c000/leds/kpdbl-pwm-3/brightness
    17443      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/leds-qpnp-f628c000/leds/kpdbl-pwm-4/brightness
    17377      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/leds-qpnp-f628c000/leds/button-backlight/brightness
    16275      0 -rw-rw-r--   1 system   android_input     4096 Mar  3  1970 /sys/devices/qcom,camera-led-flash.83/leds/torch-light/brightness
    17292      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/msm_sdcc.1/leds/mmc0::/brightness
    17335      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/msm_sdcc.2/leds/mmc1::/brightness

If 'phablet' is allowed you can try:

echo 1 > /sys/...../brightness

if not you must do it as root:

sudo bash -c "echo 1 > /sys/...../brightness"

(replace the dots with the full path) and try to echo different values (0,1,64,255)

Then it would also be interesting to show what other files reside in the same directories as the 'brightness' file. For example on opo:

phablet@ubuntu-phablet:~$ ls -l  /sys/devices/leds-qpnp-f6287e00/leds/led:flash_torch/
total 0
-rwxrwxrwx 1 system android_media 4096 Mar  3  1970 brightness
lrwxrwxrwx 1 root   root             0 Jan  7 20:33 device -> ../../../leds-qpnp-f6287e00
-rw-rw-r-- 1 root   root          4096 Jan  7 20:33 flash_blink
-rw-rw-r-- 1 root   root          4096 Jan  7 20:33 led_mode
-rw-r--r-- 1 root   root          4096 Jan  7 20:33 max_brightness
drwxr-xr-x 2 root   root             0 Mar  3  1970 power
-rw-rw-r-- 1 root   root          4096 Jan  7 20:33 strobe
lrwxrwxrwx 1 root   root             0 Jan  5 20:48 subsystem -> ../../../../class/leds
-rw-r--r-- 1 root   root          4096 Jan  7 20:33 trigger
-rw-r--r-- 1 root   root          4096 Mar  3  1970 uevent

And please post a dmesg log somewhere. Maybe this is related: https://e2e.ti.com/support/power-management/f/196/t/421131

@CiberSheep said in Spotify client:

It was a working app but
needs to be updated to Xenial.

Unfortunately that app uses an old Spotify API that is not available anymore. I will be way more work then updating it to Xenial.

I am trying to fix some issues for my opo and therefore need to build an image.
There are two documented methods I am aware of:

• http://docs.ubports.com/en/latest/porting/ubp-5.1.html
• https://github.com/ubports/device-builds

For me both do not work. The 'device-builds' one does not work at all. Building fails with various errors.

The 'docs' one builds and I can flash the boot.img and update the system.img and the phone boots etc.. However the camera stops working.

While cheking why the camera stopped working I noticed the system.img installed by the UBports Installer contains different files the the one I have built. So it seems there is yet another way to build an image.

So is there another 'howto' for building an image? Or do the before mentioned descriptions need a little bit of tweeking?

@matteo if the led support is build as a module then this module can be copied to the rootfs. If not I guess you can test a new kernel with fastboot boot which boots the kernel without installing it first.

@dobey
So repowerd will listen on dbus to set the led on/off state, color and pulse rate.
Unity will decide if and how the led should shine.

Now the thing is repowerd already knows about the battery state and the display state.
So I think part of the policy could best be done in repowerd:

• only show the led when the display is off
• indicate battery low (or hot?)
• if no other state for the led is set then show charging/full
  unity will then set the led state regarding unread messages, bluetooth or whatever comes next

But I am new here so you I'll follow your advice.

The order would then be

• move led hardware control to repowerd.
• Allow the led state to be controlled through dbus.
• Let unity use the led using dbus (extend Powerd plugin, remove Lights plugin).
• Add led indication of battery state low/charging/full.
  Question is where should this be done and how does it get the battery info?

First and maybe only release of the app is now available here: shoutcast-ubports.wdehoog_0.1_all.click

It is a shoutcast browser and player. Sources and screenshots are on github

Please give it a try. I only tested it on my moto g 2nd (thank you walidham) but like to know if it works on other devices before submitting it to the OpenStore.

Installing my click using 'pkcon...' generates a different profile file then when done manually (aa-clicktool & aa-easyprof see https://wiki.ubuntu.com/SecurityTeam/Specifications/ApplicationConfinement/Manifest). The manual way adds extra rules that allow the app to use the media-hub.

I noticed that uninstalling the app did not remove the profile. Manually removing the profile (from /var/lib/apparmor/profiles and from /var/cache/apparmor/) and then reinstalling the click resulted in a profile that could actually work.

After loading it (apparmor_parser -r) my app works!

So I think that after adding the policies in the IDE and installing the new click the previous profile (without the policies) was still being used. Question is why? Maybe because the profiles are cached and I did not increase the version number of my app.

Hi,

I am working on a app called Hutspot. It is a Spotify Controller (not a player).
It uses the Spotify web-api. Playing is done on an ‘connect’ device. It requires a premium Spotify account.

I use it on my oneplus one on which I also installed Spotifyd, a player. It is not really easy to setup nor stable so only try this if you are willing to 'mess around'.

Documentation can be found online where I also describe how I use Spotifyd.

Code is on github. Armv7 builds can be found on the releases page.

@Aury88 maybe you have to add yourself to the docker group so you get permission to run docker.

Maybe I am wrong but I noticed an almost desperate call for help at the end of the Q&A session. Too many big and difficult tasks and too few brains. The blog does not mention it though.

The post at 13 Jan 2020, 23:29 suggests it is possibe to show different blink patterns (but ofcourse all white). It would be interesting to find out how to trigger these different modes.

As for disabling the charging- or message received indication what would be the best way? A menu in the system settings? A config file in phablets home dir?

The led notifications are guarded by a unity8. How can unity8 detect what phone/hardware it is running on?

-Edit-

I have been working on a way to disable showing charging state.
See https://github.com/ubports/unity8/pull/283

@matteo if the led support is build as a module then this module can be copied to the rootfs. If not I guess you can test a new kernel with fastboot boot which boots the kernel without installing it first.

@matteo If the led went off with sudo bash -c "echo 1 > /sys/...../brightness" then you are on to something. Try other values (64, 255).
Also check what cat /sys/.../onoff says or cat /sys/.../enable.

@matteo in this link they mention a problem with the led driver your phone has (I don't have one so I could be totally wrong). And this link mentions how you could get it to show something (if it works).

So do you get any results with find /sys/bus/i2c -name select_engine or with find /sys/bus/i2c -name lp5562

@matteo to test your leds. It is also interesting to see the permissions. For example on opo:

phablet@ubuntu-phablet:~$ find /sys -name brightness -ls
    13414      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/f9924000.i2c/i2c-2/2-0068/leds/red/brightness
    13442      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/f9924000.i2c/i2c-2/2-0068/leds/blue/brightness
    13428      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/f9924000.i2c/i2c-2/2-0068/leds/green/brightness
    11561      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/mdp.0/qcom,mdss_fb_primary.169/leds/lcd-backlight/brightness
    19339      0 -rwxrwxrwx   1 system   android_media     4096 Mar  3  1970 /sys/devices/leds-qpnp-f6287e00/leds/led:flash_torch/brightness
    19303      0 -rwxrwxrwx   1 system   android_media     4096 Mar  3  1970 /sys/devices/leds-qpnp-f6287e00/leds/led:flash_0/brightness
    19320      0 -rwxrwxrwx   1 system   android_media     4096 Mar  3  1970 /sys/devices/leds-qpnp-f6287e00/leds/led:flash_1/brightness
    17399      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/leds-qpnp-f628c000/leds/kpdbl-pwm-2/brightness
    17421      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/leds-qpnp-f628c000/leds/kpdbl-pwm-3/brightness
    17443      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/leds-qpnp-f628c000/leds/kpdbl-pwm-4/brightness
    17377      0 -rw-rw-r--   1 system   android_input     4096 Jan  5 20:48 /sys/devices/leds-qpnp-f628c000/leds/button-backlight/brightness
    16275      0 -rw-rw-r--   1 system   android_input     4096 Mar  3  1970 /sys/devices/qcom,camera-led-flash.83/leds/torch-light/brightness
    17292      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/msm_sdcc.1/leds/mmc0::/brightness
    17335      0 -rw-r--r--   1 root     root              4096 Jan  7 20:27 /sys/devices/msm_sdcc.2/leds/mmc1::/brightness

If 'phablet' is allowed you can try:

echo 1 > /sys/...../brightness

if not you must do it as root:

sudo bash -c "echo 1 > /sys/...../brightness"

(replace the dots with the full path) and try to echo different values (0,1,64,255)

Then it would also be interesting to show what other files reside in the same directories as the 'brightness' file. For example on opo:

phablet@ubuntu-phablet:~$ ls -l  /sys/devices/leds-qpnp-f6287e00/leds/led:flash_torch/
total 0
-rwxrwxrwx 1 system android_media 4096 Mar  3  1970 brightness
lrwxrwxrwx 1 root   root             0 Jan  7 20:33 device -> ../../../leds-qpnp-f6287e00
-rw-rw-r-- 1 root   root          4096 Jan  7 20:33 flash_blink
-rw-rw-r-- 1 root   root          4096 Jan  7 20:33 led_mode
-rw-r--r-- 1 root   root          4096 Jan  7 20:33 max_brightness
drwxr-xr-x 2 root   root             0 Mar  3  1970 power
-rw-rw-r-- 1 root   root          4096 Jan  7 20:33 strobe
lrwxrwxrwx 1 root   root             0 Jan  5 20:48 subsystem -> ../../../../class/leds
-rw-r--r-- 1 root   root          4096 Jan  7 20:33 trigger
-rw-r--r-- 1 root   root          4096 Mar  3  1970 uevent

And please post a dmesg log somewhere. Maybe this is related: https://e2e.ti.com/support/power-management/f/196/t/421131

@matteo could you paste the whole unity8.log file?

weird stuff going on:

• sometimes deviceState is charging/discharging and sometimes it is empty

• battery level sometimes is 0

• while discharging the level goes up

@Flohack thanks a lot for helping me open my eyes.

I still don't understand the difference in vendor files but android_device_oneplus_bacon-1 seems indeed to be used for building the images.

@Flohack thanks.

I followed http://docs.ubports.com/en/latest/porting/ubp-5.1.html so ended up with the same settings as the files you point me to.
Still I think this is not what is currently being build on the ubports server and installed by the official installer.

For example branch ubp-5.1 of http://github.com/ubports/android_device_oneplus_bacon-1 has init_wlan_bt.sh in '/' of the android rootfs while on the installer image it is located in '/etc'. As I cannot find any branch that contains this file in '/etc' the ubports build server probably uses another repo. Which one?

In my locally built /system/lib/hw/ there is camera.vendor.bacon.so and in the installer one there is camera.msm8974.so. The other lib files are present but seem to differ in contents.
The files you point to use The Muppets cm-12.1 which contains camera.vendor.bacon.so not the camera.msm8974.so.
So the ubports build server probably uses another repo or branch. Which one?

To be able to continue fixing issues I now have to update the installers system.img (mount loop etc.) and reflash that.

I am trying to fix some issues for my opo and therefore need to build an image.
There are two documented methods I am aware of:

• http://docs.ubports.com/en/latest/porting/ubp-5.1.html
• https://github.com/ubports/device-builds

For me both do not work. The 'device-builds' one does not work at all. Building fails with various errors.

The 'docs' one builds and I can flash the boot.img and update the system.img and the phone boots etc.. However the camera stops working.

While cheking why the camera stopped working I noticed the system.img installed by the UBports Installer contains different files the the one I have built. So it seems there is yet another way to build an image.

So is there another 'howto' for building an image? Or do the before mentioned descriptions need a little bit of tweeking?