@dobey
So repowerd will listen on dbus to set the led on/off state, color and pulse rate.
Unity will decide if and how the led should shine.

Now the thing is repowerd already knows about the battery state and the display state.
So I think part of the policy could best be done in repowerd:

• only show the led when the display is off
• indicate battery low (or hot?)
• if no other state for the led is set then show charging/full
  unity will then set the led state regarding unread messages, bluetooth or whatever comes next

But I am new here so you I'll follow your advice.

The order would then be

• move led hardware control to repowerd.
• Allow the led state to be controlled through dbus.
• Let unity use the led using dbus (extend Powerd plugin, remove Lights plugin).
• Add led indication of battery state low/charging/full.
  Question is where should this be done and how does it get the battery info?

@dobey @Flohack
repowerd seems to do more then handling hardware. It contains a class DefaultStateMachine that also keeps track of state and for example takes care of the display dimming and turing off.
It also knows about the battery state. For the proposed led states (charging/low/full/bt/notifications) repowerd seems like a good place for now.

unity currently detects unread notifications by checking if a dbus signal (Changed) contains a "message" part with an "icon" field with a string containing "indicator-messages-new". When the display is off it sets the led. I guess repowerd can also listen to this signal.

I'll gladly move the led stuff stuff somewhere else but the current unity place (qml\Panel\Indicators\IndicatorsLight.qml) feels like the wrong one. A friend of mine (owned a ut-phone) suggested the lockscreen should manage the led state.

If it is decided that the led indicator is usefull and should be part of ubports then indeed configurability should not be overdone. Some already existing config file would allow things to be disabled if really needed.

@Flohack Thanks for your warm welcome. Not sure if I will come onboard. I am more of a drive-by developer but lets see how it rolls.

Thanks for pointing me to the Postal service. If I understand you correctly you think that it is best if this Light thinghy can be notified by dbus of certain states/changes (pending messages, bluetooth discoverability, battery low)?

Wouldn't that cause modification of lots of services/stuff to become aware if this new led controller? I am trying to keep the changes more in one place.

Above all do you agree with the approach of having this 'led authority' as you call it, located in repowerd?

I want to have the led on my phone show it is being charged or it's battery is full.
One of the core developers on telegram pointed out that this could be done by extending repowerd. So I tried to do that.

[edits] {
2019/11/09 made a PR for unity8
2019/11/07 I am now changing IndicatorsLight.qml. You can already try it. No need to build anything, just replace the qml file (keep a copy).
}

This is my first step in ubports and I have absolutely no clue of the architecture of ubports or the direction it is going into. So any development related reactions are welcome.

What I did:
Created a LightControl that does two things. Control the led (on/off/color etc) and manage the led. With managing I mean show a certain event charging, full, etc.
The battery state is monitored by UPowerPowerSource. I made it pass the BatteryInfo in its changed callback and have DefaultStateMachine pass it along.
Furthermore DefaultStateMachine also notifies display on/off.
Led styles are now hardcoded but could be made to use DeviceConfig.
Currently the led is off when the display is on. It can show charging (white pulsing) and full (solid lime green).

Choice to make

• Currently the led shows dark green when a message is 'new'. This is handled by a qml file in Unity.
  There cannot be two captains on this ship so either Unity must take care of managing the led or repowerd. I opt for repowerd.
• Should the led be controllable through dbus?

Problems

• I need information on how to know the state (or keep track of it) of pending new messages and missed calls.
• I don't have sim card in my phone. How can I test 'pending new message'?

My work can be found in the add-light branch of repo https://github.com/wdehoog/repowerd
Development is done using cross-builder. I test it on my oneplus one.

When interested to test see: https://gist.github.com/wdehoog/c7c09a792799d03e6880e10dbc19ab33

PS.
I have very strong feelings about the testing framework of repowerd. The COC probably forbids me to express them.

@CiberSheep said in Spotify client:

It was a working app but
needs to be updated to Xenial.

Unfortunately that app uses an old Spotify API that is not available anymore. I will be way more work then updating it to Xenial.

@ricardo65
Unfortunately multirom images for recent ubports seem not available.

Am I right to conclude you got sailfish 3.0.1.11 working but after pkcon update it fails?

If not please start here https://github.com/wdehoog/sailfish-bacon-images/wiki on looking how to install sailfish on your oneplus one. If you have an unaddresses problem you can create an Issue on github.

@ricardo65
Sorry for asking but what exactly are you doing? Which files are you using to flash ubports? Which files are you using to flash sailfish? What do you mean with 'when updating sailfish'? Which installed system does not start?

Hi,

The oneplus one is definately supported. I have run it myself. Installing UBPorts can happen in a breeze but might also be problematic. As you will undoubtedly have seen this when searching in this forum. There are various ways to install it. One of them seems not to work for you. So you can try another one or find out why this one does not work.

For me the installers did not work since my phone could not be accessed using adb. It remained 'unauthorized'. In the end I used the script the UBPorts developers use but this is considered a last resort.

So I would suggest to first verify your phone is accessible by adb when in recovery mode.

@Einstein212 I did not know about soundcloud and now see that it supports a lot of features. It will be no small effort. As it is of no use to me I am not going to work on it. If you are a developer yourself and need help I might be of use.

There is a project on github that could be of interest to you https://github.com/lukedirtwalker/musikloud2 looks like a soundcloud client for sailfish maybe parts can be used for a ubports app.

@Einstein212 did the icon not appear after refreshing home (pull down to refresh)?

Does soundcloud have an API to browse/search and retrieve lists?