Test alternative pin code prompt - system settings integration

lduboeuf

@cibersheep said in Test alternative pin code prompt - system settings integration:

@lduboeuf very nice work.
Only one think is in my mind, and I think it's what you tried to tell me before. When the pin clock is already set: tapping on the ListItem asks for current pin. Do you think it would be more clear to have?:

show [test pin pattern] with edit icon on header

tap on edit

ask for current pin pattern

ask for new pin pattern

ask for verification

if verification is correct, go back

Is a bit unusual to have a tester for the current pin, but...
What do you think?

That makes sense . But i like the idea of user confirmation with the "ok" in the top bar when the verification is correct, the "back" would be more a "cancel" action for me.

[EDIT]: Well something bother me. When you are in the "test screen", what do you test ? Because i'm pretty sure we can't check login on backend like we want. So i think we must go to "confirm" first.

CiberSheep

@lduboeuf said in Test alternative pin code prompt - system settings integration:

That makes sense . But i like the idea of user confirmation with the "ok" in the top bar when the verification is correct, the "back" would be more a "cancel" action for me.

Agreed

[EDIT]: Well something bother me. When you are in the "test screen", what do you test ? Because i'm pretty sure we can't check login on backend like we want. So i think we must go to "confirm" first.

Ah, I see. I mean, it's a bit weird that you have a test screen for the current pin pattern.
What I feel is that is a bit unclear of resetting the pin pattern when tapping on the ListView:

Once setted the pin pattern before
Opening System setting /[...]/Security
Tapping on pin pattern, it will ask for:

- current pin
- new pin
- confirm pin

Is here (*) I feel it unclear. It is for us because we know what we are doing

Do you know what I mean?

lduboeuf

@cibersheep i pushed some modifications, let me know.
And i add a "V3" to test selecting the "clock prompt" as a sub option of "4 digit passcode" and just let user "preview" (test) the clock prompt ( the user won't create his passcode through clock that time as he already created/changed it before with classic popup)
This is the "simpliest" solution as it would not require to change backend methods and having to deal with pincode change through the clock.

CiberSheep

@lduboeuf Yep, V3 is much simpler indeed
There is no way to edit the pin (like current behaviour), so you have to unset and reset it.
You think the test screen in V3 is required for real use?

lduboeuf

@cibersheep said in Test alternative pin code prompt - system settings integration:

@lduboeuf Yep, V3 is much simpler indeed
There is no way to edit the pin (like current behaviour), so you have to unset and reset it.

Humm, true.
So when user click on ""4-digit passcode":
(pincode not set): -> popup -> "4-digit pin" view
(pincode already set): -> "4-digit pin" view with "edit" button

You think the test screen in V3 is required for real use?

idk, it would be even simpler if we remove the preview.

EDIT: see 1.7.3 for the use case "pincode already set"

CiberSheep

@lduboeuf said in Test alternative pin code prompt - system settings integration:

You think the test screen in V3 is required for real use?

idk, it would be even simpler if we remove the preview.

You decide
Maybe we can have it as a feature reveal, and if you think it's not needed any more, it can be removed later when the feature is established. Or keep it if it's useful even then...

EDIT: see 1.7.3 for the use case "pincode already set"

Hmh, I like. Do you?

lduboeuf

@cibersheep said in Test alternative pin code prompt - system settings integration:

Hmh, I like. Do you?

Yes, i prefer, i will go without the tester i think, it can be more confusing than helpful for some and i don't like that button in the middle

Ian

Just tried the V3 scenario. It looks good, it makes sense, and it works well. Could you add this to OTA 23 (or 24 if too late now) and see how it goes when 'released into the wild'?

Thanks for working on this feature and introducing the concept of the tester. This could well be the future of new feature introduction!

lduboeuf

@ian thx, so i've implemented the V3 in system-settings https://gitlab.com/ubports/core/lomiri-system-settings/-/merge_requests/328/ and removed the preview.

Now, it is too short to add it to OTA-23, lets hope it will land on OTA-24

JeroenBaten

Hi!
Lovely design!
What I am missing is some sort of randomizing option. To prevent people from reading a passcode by watching the fat smear on the display. If I could toggle a randomize option it would make it much harder to break into the system.
I realise this is not very nice to blind people using an UT phone, but there are other options for them.
Regards,
Jeroen Baten

lduboeuf

@jeroenbaten We could improve later i think, but i'm afraid every one would want a different setting...
and i've already tested random digits, it is more annoying than helpful, it takes too long to find your digits ^ ^
I think we can compare like it is today, the pin-code prompts have a keyboard always in the same layout, and we can see on screen what keys we tap.

jezek

@lduboeuf said in Test alternative pin code prompt - system settings integration:

and i've already tested random digits, it is more annoying than helpful, it takes too long to find your digits ...

Pardon my intrusion. Maybe they don't have to be random, they can be rotated by random places (the order will be preserved), have you tried that?

But I agree, that can wait.

lduboeuf

@jezek no i haven't tested that use case.
We can imagine lots of tunings

dizzy

Dont overwork it. Its fine as it is. If you need something more secure, use a proper password. My two cents...

Keneda

Even if not for now, a randomizer could be great.
A compromise between "fast" and "more secure".
Optionnal so people that don't want it can stay the fastest way.

@lduboeuf said in Test alternative pin code prompt - system settings integration:

I think we can compare like it is today, the pin-code prompts have a keyboard always in the same layout, and we can see on screen what keys we tap.

That could be randomisable too (optionnal again), like my bank is doing for account access.

messayisto

@keneda Should this feature not be in OTA 22?

lduboeuf

@messayisto OTA-24 if it does not break everything and the reviewer have time to look at it

messayisto

@lduboeuf nice - thank you!

Rondarius

Hi
Just want to tell everybody that this feature has been implemented and has been for a long time. you find it under:
Settings/Security & Privacy/Locking & unlocking/Lock security/Passcode/Circle pattern